802739 - Make parent wrapping for DOM bindings fall back to XPConnect for nsISupports classes

Status: RESOLVED FIXED

(Core :: DOM: Core & HTML, defect)

Description

[Peter Van der Beken [:peterv]]

Attachment: v1

Bug 799465 made us support non-nsISupports classes as parents, but it breaks using as parents nsISupports classes that can be prefed off, we don't fall back to using XPConnect if calling WrapObject failed because we prefed off the binding.

I found a solution to check for classes (including base classes) having a member, and it should work on the compilers we support (http://stackoverflow.com/questions/9599693/checking-a-member-exists-possibly-in-a-base-class-vs2005-08-version). With this I can check for AddRef/Release/QueryInterface to detect nsISupports classes, and specify fallback to XPConnect for them. These checks should also allow us to remove nativeOwnership from the config file in the future.

Comment 1

[Peter Van der Beken [:peterv]]

This blocks bug 773780 because that patch adds nsINode::WrapObject which doesn't currently wrap anything, because we haven't converted any nodes.

Comment 2

[Boris Zbarsky [:bzbarsky]]

Comment on attachment 672427 [details] [diff] [review]
v1

r=me.  This is getting hairy.  :(

Comment 3

[Peter Van der Beken [:peterv]]

https://hg.mozilla.org/integration/mozilla-inbound/rev/03fba4879674

Comment 4

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/mozilla-central/rev/03fba4879674