802753 - TEST-UNEXPECTED-FAIL : AttributeError: 'TestGetStatus' object has no attribute 'assertIn'

Status: RESOLVED FIXED

(Remote Protocol :: Marionette, defect)

Description

[Jonathan Griffin (:jgriffin)]

On TBPL, TestGetStatus is failing with:

19:36:14     INFO -  ======================================================================
19:36:14     INFO -  ERROR: test_getStatus (test_getstatus.TestGetStatus)
19:36:14     INFO -  ----------------------------------------------------------------------
19:36:14    ERROR -  Traceback (most recent call last):
19:36:14     INFO -    File "/home/cltbld/talos-slave/test/build/tests/marionette/tests/testing/marionette/client/marionette/tests/unit/test_getstatus.py", line 10, in test_getStatus
19:36:14     INFO -      self.assertIn("os", status)
19:36:14     INFO -  TEST-UNEXPECTED-FAIL : AttributeError: 'TestGetStatus' object has no attribute 'assertIn'

This probably is a Python 2.6 compatibility issue.  Many test slaves only have Python 2.6.  We should change these assert statements not to use assertIn.

log:  https://tbpl.mozilla.org/php/getParsedLog.php?id=16180135&tree=Firefox&full=1#error0

Comment 1

[Malini Das [:mdas] - Away, not checking bugmail]

Attachment: patch v1.0

Sorry, that was my fault, I was testing with python2.7

I added the changes in this patch, and tested it against 2.6.6, and it works.

Comment 2

[Jonathan Griffin (:jgriffin)]

Comment on attachment 672460 [details] [diff] [review]
patch v1.0

Review of attachment 672460 [details] [diff] [review]:
-----------------------------------------------------------------

Thanks for the quick fix!

Comment 3

[Malini Das [:mdas] - Away, not checking bugmail]

landed in m-i:

https://hg.mozilla.org/integration/mozilla-inbound/rev/130f0da363c8

Comment 4

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/mozilla-central/rev/130f0da363c8

Comment 5

[Jonathan Griffin (:jgriffin)]

Landed in aurora: https://hg.mozilla.org/releases/mozilla-aurora/rev/72b50096eab2