Closed
Bug 802809
Opened 12 years ago
Closed 12 years ago
IonMonkey: assert that PRESET LDefinitions are followed by LNop
Categories
(Core :: JavaScript Engine, defect)
Core
JavaScript Engine
Tracking
()
RESOLVED
FIXED
mozilla19
People
(Reporter: luke, Assigned: jandem)
Details
(Whiteboard: [ion:t])
Attachments
(1 file)
|
3.37 KB,
patch
|
dvander
:
review+
|
Details | Diff | Splinter Review |
As explained by the comment in defineFixed, this is necessary for better register allocation when a PRESET definition is followed by a FIXED use. One place this is currently missing is the lowering of MParameter, so maybe this will be a slight speedup.
|
||
Updated•12 years ago
|
Whiteboard: [ion:t]
|
Assignee | |
Comment 1•12 years ago
|
||
This is not a problem for LParameter because its (fixed) output is not a register but a memory location. The patch just asserts the next instruction has no fixed uses, it's usually LNop or LOsiPoint.
|
|
||
Updated•12 years ago
|
Attachment #675229 -
Flags: review?(dvander) → review+
|
|
Assignee | |
Comment 2•12 years ago
|
||
https://hg.mozilla.org/integration/mozilla-inbound/rev/de38abf9266e
|
||
Comment 3•12 years ago
|
||
https://hg.mozilla.org/mozilla-central/rev/de38abf9266e
Status: ASSIGNED → RESOLVED
Closed: 12 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla19
|
|
||
Comment 4•12 years ago
|
||
https://hg.mozilla.org/mozilla-central/rev/de38abf9266e
You need to log in
before you can comment on or make changes to this bug.
Description
•