802809 - IonMonkey: assert that PRESET LDefinitions are followed by LNop

Status: RESOLVED FIXED

(Core :: JavaScript Engine, defect)

Description

[Luke Wagner [:luke]]

As explained by the comment in defineFixed, this is necessary for better register allocation when a PRESET definition is followed by a FIXED use.  One place this is currently missing is the lowering of MParameter, so maybe this will be a slight speedup.

Comment 1

[Jan de Mooij [:jandem]]

Attachment: Patch

This is not a problem for LParameter because its (fixed) output is not a register but a memory location. The patch just asserts the next instruction has no fixed uses, it's usually LNop or LOsiPoint.

Comment 2

[Jan de Mooij [:jandem]]

https://hg.mozilla.org/integration/mozilla-inbound/rev/de38abf9266e

Comment 3

[Ed Morley [:emorley]]

https://hg.mozilla.org/mozilla-central/rev/de38abf9266e

Comment 4

[Ed Morley [:emorley]]

https://hg.mozilla.org/mozilla-central/rev/de38abf9266e