Closed Bug 802856 Opened 7 years ago Closed 7 years ago

Plugins don't always get focused in HiDPI mode if you click on them

Categories

(Core :: Plug-ins, defect)

x86
macOS
defect
Not set

Tracking

()

RESOLVED FIXED
mozilla19

People

(Reporter: smichaud, Assigned: smichaud)

References

(Blocks 1 open bug)

Details

Attachments

(1 file)

This problem has existed since the patches for bug 674373 landed.  It doesn't happen in non-HiDPI mode, or if you turn off HiDPI support by setting gfx.hidpi.enabled to '-1' (in about:config) and restart the browser.

You can see it by testing with my Debug Events Plugin from bug 441880.  The plugin's background is grey if it isn't focused, and white if it is focused.  Notice that it will get focused only if you click (roughly) somewhere in its lower-right quarter.

I have a patch for this, which I'll post shortly.
Blocks: 674373
Attached patch FixSplinter Review
One more place we need a conversion from display pixels to device pixels.
Assignee: nobody → smichaud
Attachment #672573 - Flags: review?(jfkthame)
Attachment #672573 - Flags: review?(jfkthame) → review+
https://hg.mozilla.org/mozilla-central/rev/06777f847494
Status: NEW → RESOLVED
Closed: 7 years ago
Flags: in-testsuite-
Resolution: --- → FIXED
Target Milestone: --- → mozilla19
You need to log in before you can comment on or make changes to this bug.