Build libeditor/html fail for DebugOnly<nsresult> == NS_OK with --enable-debug

RESOLVED FIXED in mozilla19

Status

()

Core
Editor
RESOLVED FIXED
6 years ago
4 years ago

People

(Reporter: romaxa, Assigned: Ehsan)

Tracking

unspecified
mozilla19
x86_64
Windows 8.1
Points:
---

Firefox Tracking Flags

(Not tracked)

Details

(Reporter)

Description

6 years ago
objdir-x86\dist\include\FrameMetrics.h(89) : warning C4244: 'argument' : con
version from 'gfxFloat' to 'mozilla::gfx::Float', possible loss of data
editor/libeditor/html/nsHTMLEditor.cpp(769) : error C2678: b
inary '==' : no operator found which takes a left-hand operand of type 'mozilla::DebugOnly<T>' (or t
here is no acceptable conversion)
        with
        [
            T=nsresult
        ]
        objdir-x86\dist\include\nsTSubstring.h(851): could be 'bool operator
 ==(const nsAString_internal::base_string_type &,const nsAString_internal::base_string_type &)'
        objdir-x86\dist\include\nsTSubstring.h(851): or       'bool operator
 ==(const nsACString_internal::base_string_type &,const nsACString_internal::base_string_type &)'
        objdir-x86\dist\include\nsChangeHint.h(126): or       'void operator
 ==(nsChangeHint,nsChangeHint)'
        objdir-x86\dist\include\gfxFontFeatures.h(24): or       'bool operat
or ==(const gfxFontFeature &,const gfxFontFeature &)'
        mozilla-central\editor\libeditor\html\nsWSRunObject.h(69): or
'bool operator ==(const WSType &,const WSType &)'
        while trying to match the argument list '(mozilla::DebugOnly<T>, tag_nsresult)'
        with
        [
            T=nsresult
        ]
editor/libeditor/html/nsHTMLEditor.cpp(3416) : warning C4267
: 'initializing' : conversion from 'size_t' to 'int32_t', possible loss of data
make[2]: *** [nsHTMLEditor.obj] Error 2
(Assignee)

Comment 1

6 years ago
Ah, this is a compiler bug, and I thought I fixed it.  Here's the fix anyways: https://hg.mozilla.org/integration/mozilla-inbound/rev/205475d5c2b7
Assignee: nobody → ehsan
Blocks: 779473

Comment 2

6 years ago
https://hg.mozilla.org/mozilla-central/rev/205475d5c2b7
Status: NEW → RESOLVED
Last Resolved: 6 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla19
OS: Windows 8 Metro → Windows 8.1
You need to log in before you can comment on or make changes to this bug.