Note: There are a few cases of duplicates in user autocompletion which are being worked on.

Remove aType parameter from AddonUpdateChecker.checkForUpdates and UpdateParser

RESOLVED FIXED in mozilla19

Status

()

Toolkit
Add-ons Manager
RESOLVED FIXED
5 years ago
5 years ago

People

(Reporter: Unfocused, Assigned: eduardn)

Tracking

Trunk
mozilla19
Points:
---

Firefox Tracking Flags

(Not tracked)

Details

(Whiteboard: [good first bug][mentor=bmcbride@mozilla.com][lang=js])

Attachments

(1 attachment)

Bug 782118 deprecated differentiating add-on types in update manifests. Since then, it's no longer necessary to pass in the add-on type to AddonUpdateChecker.checkForUpdates and UpdateParser - so we should remove that parameter.

These functions are defined in:
https://mxr.mozilla.org/mozilla-central/source/toolkit/mozapps/extensions/AddonUpdateChecker.jsm

And used here:
https://mxr.mozilla.org/mozilla-central/search?string=AddonUpdateChecker.checkForUpdates
(Assignee)

Comment 1

5 years ago
I would like to work on this bug!
Great! I've assigned the bug to you.

If you haven't got a copy of the code and built Firefox yet, have a read through:
https://developer.mozilla.org/en-US/docs/Simple_Firefox_build

And more generally:
https://developer.mozilla.org/en-US/docs/Developer_Guide
Assignee: nobody → eduardnem
Status: NEW → ASSIGNED
(Assignee)

Comment 3

5 years ago
Created attachment 674667 [details] [diff] [review]
First patch
Attachment #674667 - Flags: review?(bmcbride)
Comment on attachment 674667 [details] [diff] [review]
First patch

Review of attachment 674667 [details] [diff] [review]:
-----------------------------------------------------------------

This is perfect - awesome job :)

Will check this into the tree for you soon.
Attachment #674667 - Flags: review?(bmcbride) → review+
(Assignee)

Comment 5

5 years ago
Great, thanks!
Landed on the fx-team branch, which should get merged into mozilla-central within a day.

https://hg.mozilla.org/integration/fx-team/rev/9dbdbab1e38d
Whiteboard: [good first bug][mentor=bmcbride@mozilla.com][lang=js] → [good first bug][mentor=bmcbride@mozilla.com][lang=js][fixed-in-fx-team]
Target Milestone: --- → mozilla19
https://hg.mozilla.org/mozilla-central/rev/9dbdbab1e38d
Status: ASSIGNED → RESOLVED
Last Resolved: 5 years ago
Resolution: --- → FIXED
Whiteboard: [good first bug][mentor=bmcbride@mozilla.com][lang=js][fixed-in-fx-team] → [good first bug][mentor=bmcbride@mozilla.com][lang=js]
You need to log in before you can comment on or make changes to this bug.