Last Comment Bug 802945 - Remove aType parameter from AddonUpdateChecker.checkForUpdates and UpdateParser
: Remove aType parameter from AddonUpdateChecker.checkForUpdates and UpdateParser
[good first bug][mentor=bmcbride@mozi...
Product: Toolkit
Classification: Components
Component: Add-ons Manager (show other bugs)
: Trunk
: All All
-- normal (vote)
: mozilla19
Assigned To: Eduard Neculaesi (:eduardn)
: Andy McKay [:andym]
Depends on: 782118
  Show dependency treegraph
Reported: 2012-10-17 21:39 PDT by Blair McBride [:Unfocused] (UNAVAILABLE)
Modified: 2012-10-25 12:28 PDT (History)
2 users (show)
See Also:
Crash Signature:
QA Whiteboard:
Iteration: ---
Points: ---
Has Regression Range: ---
Has STR: ---

First patch (15.98 KB, patch)
2012-10-24 08:20 PDT, Eduard Neculaesi (:eduardn)
blair: review+
Details | Diff | Splinter Review

Description User image Blair McBride [:Unfocused] (UNAVAILABLE) 2012-10-17 21:39:06 PDT
Bug 782118 deprecated differentiating add-on types in update manifests. Since then, it's no longer necessary to pass in the add-on type to AddonUpdateChecker.checkForUpdates and UpdateParser - so we should remove that parameter.

These functions are defined in:

And used here:
Comment 1 User image Eduard Neculaesi (:eduardn) 2012-10-22 08:53:44 PDT
I would like to work on this bug!
Comment 2 User image Blair McBride [:Unfocused] (UNAVAILABLE) 2012-10-22 19:08:16 PDT
Great! I've assigned the bug to you.

If you haven't got a copy of the code and built Firefox yet, have a read through:

And more generally:
Comment 3 User image Eduard Neculaesi (:eduardn) 2012-10-24 08:20:03 PDT
Created attachment 674667 [details] [diff] [review]
First patch
Comment 4 User image Blair McBride [:Unfocused] (UNAVAILABLE) 2012-10-24 21:44:24 PDT
Comment on attachment 674667 [details] [diff] [review]
First patch

Review of attachment 674667 [details] [diff] [review]:

This is perfect - awesome job :)

Will check this into the tree for you soon.
Comment 5 User image Eduard Neculaesi (:eduardn) 2012-10-24 23:58:49 PDT
Great, thanks!
Comment 6 User image Blair McBride [:Unfocused] (UNAVAILABLE) 2012-10-25 04:55:26 PDT
Landed on the fx-team branch, which should get merged into mozilla-central within a day.
Comment 7 User image Tim Taubert [:ttaubert] 2012-10-25 12:28:10 PDT

Note You need to log in before you can comment on or make changes to this bug.