802945 - Remove aType parameter from AddonUpdateChecker.checkForUpdates and UpdateParser

Status: RESOLVED FIXED

(Toolkit :: Add-ons Manager, defect)

Description

[Blair McBride [:Unfocused] (UNAVAILABLE)]

Bug 782118 deprecated differentiating add-on types in update manifests. Since then, it's no longer necessary to pass in the add-on type to AddonUpdateChecker.checkForUpdates and UpdateParser - so we should remove that parameter.

These functions are defined in:
https://mxr.mozilla.org/mozilla-central/source/toolkit/mozapps/extensions/AddonUpdateChecker.jsm

And used here:
https://mxr.mozilla.org/mozilla-central/search?string=AddonUpdateChecker.checkForUpdates

Comment 1

[Eduard Neculaesi (:eduardn)]

I would like to work on this bug!

Comment 2

[Blair McBride [:Unfocused] (UNAVAILABLE)]

Great! I've assigned the bug to you.

If you haven't got a copy of the code and built Firefox yet, have a read through:
https://developer.mozilla.org/en-US/docs/Simple_Firefox_build

And more generally:
https://developer.mozilla.org/en-US/docs/Developer_Guide

Comment 3

[Eduard Neculaesi (:eduardn)]

Attachment: First patch

Comment 4

[Blair McBride [:Unfocused] (UNAVAILABLE)]

Comment on attachment 674667 [details] [diff] [review]
First patch

Review of attachment 674667 [details] [diff] [review]:
-----------------------------------------------------------------

This is perfect - awesome job :)

Will check this into the tree for you soon.

Comment 5

[Eduard Neculaesi (:eduardn)]

Great, thanks!

Comment 6

[Blair McBride [:Unfocused] (UNAVAILABLE)]

Landed on the fx-team branch, which should get merged into mozilla-central within a day.

https://hg.mozilla.org/integration/fx-team/rev/9dbdbab1e38d

Comment 7

[Tim Taubert [:ttaubert] (inactive)]

https://hg.mozilla.org/mozilla-central/rev/9dbdbab1e38d