Closed Bug 802989 Opened 9 years ago Closed 9 years ago

[OS.File] Fix documentation of OS.Path

Categories

(Toolkit :: OS.File, defect)

defect
Not set
normal

Tracking

()

RESOLVED FIXED
mozilla22

People

(Reporter: Yoric, Assigned: Cykesiopka)

Details

Attachments

(1 file, 1 obsolete file)

Documentation of OS.Path still uses OS.Path.to. This should be updated.
I should add that this is the *in source* documentation, not the MDN hosted doc.
Attached patch Proposed Patch v1 (obsolete) — Splinter Review
Hopefully this is what you wanted...
Attachment #728562 - Flags: review?(dteller)
Comment on attachment 728562 [details] [diff] [review]
Proposed Patch v1

Review of attachment 728562 [details] [diff] [review]:
-----------------------------------------------------------------

That's what I wanted indeed. I believe that it would be slightly easier to read in two lines, though, as it was before:
  var tmpDir = ...
  var path = ...
Attachment #728562 - Flags: review?(dteller) → review+
Attached patch Patch v2Splinter Review
Reverted to two lines, as before.

The MDN docs use the single line version as the example... Should I update that as well?
Assignee: nobody → cykesiopka
Attachment #728562 - Attachment is obsolete: true
Status: NEW → ASSIGNED
Attachment #728600 - Flags: review?(dteller)
Oops, is this one of those situations where I can "carry r+"? Still not very familiar with the review system unfortunately...
Comment on attachment 728600 [details] [diff] [review]
Patch v2

Review of attachment 728600 [details] [diff] [review]:
-----------------------------------------------------------------

Yes, you could carry the r+.
And yes, if you could update the MDN version, that would be great.

Thanks for the patch!
Attachment #728600 - Flags: review?(dteller) → review+
No problem!

I've updated the MDN docs as well.
Keywords: checkin-needed
https://hg.mozilla.org/mozilla-central/rev/f15682d66f5f
Status: ASSIGNED → RESOLVED
Closed: 9 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla22
You need to log in before you can comment on or make changes to this bug.