Closed
Bug 802989
Opened 8 years ago
Closed 8 years ago
[OS.File] Fix documentation of OS.Path
Categories
(Toolkit :: OS.File, defect)
Toolkit
OS.File
Tracking
()
RESOLVED
FIXED
mozilla22
People
(Reporter: Yoric, Assigned: Cykesiopka)
Details
Attachments
(1 file, 1 obsolete file)
1.93 KB,
patch
|
Yoric
:
review+
|
Details | Diff | Splinter Review |
Documentation of OS.Path still uses OS.Path.to. This should be updated.
Reporter | ||
Comment 1•8 years ago
|
||
I should add that this is the *in source* documentation, not the MDN hosted doc.
![]() |
Assignee | |
Comment 2•8 years ago
|
||
Hopefully this is what you wanted...
Attachment #728562 -
Flags: review?(dteller)
Reporter | ||
Comment 3•8 years ago
|
||
Comment on attachment 728562 [details] [diff] [review] Proposed Patch v1 Review of attachment 728562 [details] [diff] [review]: ----------------------------------------------------------------- That's what I wanted indeed. I believe that it would be slightly easier to read in two lines, though, as it was before: var tmpDir = ... var path = ...
Attachment #728562 -
Flags: review?(dteller) → review+
![]() |
Assignee | |
Comment 4•8 years ago
|
||
Reverted to two lines, as before. The MDN docs use the single line version as the example... Should I update that as well?
Assignee: nobody → cykesiopka
Attachment #728562 -
Attachment is obsolete: true
Status: NEW → ASSIGNED
Attachment #728600 -
Flags: review?(dteller)
![]() |
Assignee | |
Comment 5•8 years ago
|
||
Oops, is this one of those situations where I can "carry r+"? Still not very familiar with the review system unfortunately...
Reporter | ||
Comment 6•8 years ago
|
||
Comment on attachment 728600 [details] [diff] [review] Patch v2 Review of attachment 728600 [details] [diff] [review]: ----------------------------------------------------------------- Yes, you could carry the r+. And yes, if you could update the MDN version, that would be great. Thanks for the patch!
Attachment #728600 -
Flags: review?(dteller) → review+
![]() |
Assignee | |
Comment 7•8 years ago
|
||
No problem! I've updated the MDN docs as well.
Keywords: checkin-needed
Comment 8•8 years ago
|
||
https://hg.mozilla.org/integration/mozilla-inbound/rev/f15682d66f5f
Keywords: checkin-needed
Comment 9•8 years ago
|
||
https://hg.mozilla.org/mozilla-central/rev/f15682d66f5f
Status: ASSIGNED → RESOLVED
Closed: 8 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla22
You need to log in
before you can comment on or make changes to this bug.
Description
•