802999 - [AccessFu] Typed keys no longer echoed back by TalkBak in web content

Status: VERIFIED FIXED

(Core :: Disability Access APIs, defect)

Description

[Marco Zehe (:MarcoZ)]

Regression. Used to work, despite other editing problems like not being able to re-read character by character what one typed. But keyboard echo used to work in 17.

STR:
1. Open a web page that has an input type text field. Notice that while typing the URL in the awesome bar, characters are echoed back.
2. Touch, then double-tap to focus that input.
3. Start typing.

Expected: Each character should be heard twice, once when touching it, once after lifting the finger to actually enter it.
Actual: Only the touch part is heard. When lifting the finger, the entered character is no longer echoed back.

Impact: Sometimes, the finger may slide to the adjacent character right before lifting, and another character is entered. It is important to be able to hear what one actually typed.

Comment 1

[Eitan Isaacson [:eeejay]]

Attachment: Fixed android textChanged presenter.

Comment 2

[David Bolter [:davidb] (NeedInfo me for attention)]

Comment on attachment 673391 [details] [diff] [review]
Fixed android textChanged presenter.

Review of attachment 673391 [details] [diff] [review]:
-----------------------------------------------------------------

Ouch. Sorry I let that through.

Comment 3

[Eitan Isaacson [:eeejay]]

https://hg.mozilla.org/integration/mozilla-inbound/rev/43eca3085ddc

Comment 4

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/mozilla-central/rev/43eca3085ddc

Comment 5

[Marco Zehe (:MarcoZ)]

Verified fixed in the 2012-10-20 nightly build.

Comment 6

[Marco Zehe (:MarcoZ)]

Comment on attachment 673391 [details] [diff] [review]
Fixed android textChanged presenter.

[Approval Request Comment]
Bug caused by (feature/regressing bug #): B2G reorg to account for out-of-process web apps
User impact if declined: Users will not hear typed characters in inputs on the web through TalkBack, not be able to control what they typed.
Testing completed (on m-c, etc.): Yes.
Risk to taking this patch (and alternatives if risky): None.
String or UUID changes made by this patch: None known.

Comment 7

[bhavana bajaj [:bajaj]]

Comment on attachment 673391 [details] [diff] [review]
Fixed android textChanged presenter.

Approving for aurora considering its a regression & the user impact for our accessibility users

Comment 8

[Eitan Isaacson [:eeejay]]

http://hg.mozilla.org/releases/mozilla-aurora/rev/aa8b5809514c