803049 - [Gallery] Previews appear and disappear

Status: VERIFIED FIXED

(Firefox OS Graveyard :: Gaia, defect, P1)

Description

[David Scravaglieri [:scravag]]

Changeset
gecko: bbf233397549175223da3687bc5678d91685e54a
gaia: bb84a2a130fd669713986390292538a9bdbd3469

Device: otoro (unagi ?)

1- Launch Gallery
2- See photos preview

Expected: Photos preview

Actual: Photo preview appear and disapear randomly. Looks like a repaint bug.

Comment 1

[Ben Francis [:benfrancis]]

Please re-nom if anyone else can reproduce, we couldn't reproduce in triage.

Comment 2

[David Scravaglieri [:scravag]]

reproduced by massimo in smoke test
https://docs.google.com/spreadsheet/ccc?key=0AqDJxnTd7VDLdDRKOE1uanE3M3FtMDBOVjRIV253S1E#gid=23

Comment 4

[Tony Chung [:tchung]]

Attachment: screenshot

screenshot of missing thumbnail previews in gallery

Comment 5

[Andrew Overholt [:overholt]]

djf, who can fix this?

Comment 6

[David Flanagan [:djf]]

(In reply to Andrew Overholt [:overholt] from comment #5)
> djf, who can fix this?

I'll add this bug to my list and investigate. Either its my bug and I can fix it, or there's a platform bug, but I won't know without digging into it.

Comment 7

[David Flanagan [:djf]]

I have a hunch that this is actually a memory-related issue.  

Tony, it would be great if you could apply the patch in the PR https://github.com/mozilla-b2g/gaia/pull/6034 and then run make reset-gaia and see if you can still reproduce it.

(Note that the reset-gaia is required. Just make install-gaia isn't enough; it needs to blow away the gallery's existing database.)

Comment 8

[Tony Chung [:tchung]]

Guys, we're treating this as a dogfood blocker, smoketest bug.   I would suggest reprioritizing this one higher, as it's easily reproducible if you have a large set of images.

David, i havent been able to apply patches to my daily builds we're testing on.   has this PR been merged yet into gaia nightly?

Comment 9

[Dylan Oliver [:doliver]]

Re-prioritized as smoketest blocker.

Comment 10

[Vivien Nicolas (:vingtetun) (:21) - (NOT reading bugmails, needinfo? please)]

(In reply to David Flanagan [:djf] from comment #7)
> I have a hunch that this is actually a memory-related issue.  
> 
> Tony, it would be great if you could apply the patch in the PR
> https://github.com/mozilla-b2g/gaia/pull/6034 and then run make reset-gaia
> and see if you can still reproduce it.
> 
> (Note that the reset-gaia is required. Just make install-gaia isn't enough;
> it needs to blow away the gallery's existing database.)

This fix the issue for me.

Comment 11

[David Flanagan [:djf]]

So the fix I've got for this issue apparently does not fix #805114.  People who can't open the app at all still will not be able to open the app.  But those who can will find it usable.  So that's progress, at least.

I'll clean up the patch and try to get it landed.  I'll also modify the patch so that it bumps the database version number and does not require a make reset-gaia.

Comment 12

[David Flanagan [:djf]]

I should note that my patch addresses this bug by using smaller thumbnail images, which is something that needs to happen anyway.

But it doesn't touch whatever underlying gecko change has caused the bug.  Nothing changed in gallery to cause this bug, and I suspect that something has changed in the platform.

Comment 13

[David Flanagan [:djf]]

Fixed (I think) in https://github.com/mozilla-b2g/gaia/pull/6034

That should fix the smoketest blocker. 

I'm reluctant to close the bug, though, because I think there is some kind of platform issue going on. If I can come up with a test case that demonstrates the platform bug, I'll close this one.

Comment 14

[David Flanagan [:djf]]

Closing this bug now because it is specific to gallery, and I've landed a gallery-specific workaround.

The more general gecko regression is now in #807143

Comment 15

[Rebecca Billings [:rbillings]]

Verified the previews display correctly on the 11/28 unagi build.