803165 - [OS.File] No OS.File for Gonk

Status: RESOLVED FIXED

(Toolkit Graveyard :: OS.File, defect)

Description

[Alexandre Poirot [:ochameau]]

When adding:
  Components.utils.import("resource://gre/modules/osfile.jsm")
On top of:
  http://mxr.mozilla.org/mozilla-central/source/dom/apps/src/Webapps.jsm
I got the following exception:
[JavaScript Error: "NS_ERROR_XPC_BAD_IID: Component returned failure code: 0x80570018 (NS_ERROR_XPC_BAD_IID) [nsIJSCID.getService]" file: "resource://gre/modules/osfile/osfile_shared_allthreads.jsm" line: 31}]

When running on the device. (I haven't tried on desktop)

Comment 1

[David Teller [:Yoric] - still alive but not very active]

It sounds like nsIOSFileConstantsService.{idl, xpt} is not installed on Gonk.

What file controls the list of idl/xpt installed on Gonk?

Comment 2

[David Teller [:Yoric] - still alive but not very active]

Attachment: Adding the interface to the installer

Comment 3

[David Teller [:Yoric] - still alive but not very active]

ochameau, any chance you could check if this patch solves the issue for you?

Comment 4

[Josh Matthews [:jdm]]

http://mxr.mozilla.org/mozilla-central/source/browser/installer/package-manifest.in#167
vs.
http://mxr.mozilla.org/mozilla-central/source/b2g/installer/package-manifest.in#158

Comment 5

[David Teller [:Yoric] - still alive but not very active]

Attachment: Adding dom_system.xpt to the installer

Comment 6

[Alexandre Poirot [:ochameau]]

Fix the original exception but it's being replaced by a new one:
JavaScript Error: "OS.Constants is undefined" {file: "resource://gre/modules/osfile/osfile_async_front.jsm" line: 36}

Comment 7

[David Teller [:Yoric] - still alive but not very active]

Ok, as I feared, the binary component is not installed in Gonk. I will need to find how to remedy this.

Comment 8

[Josh Matthews [:jdm]]

David the patch you attached did not match the description. Did you mean one that addressed comment 4?

Comment 9

[David Teller [:Yoric] - still alive but not very active]

Attachment: Adding dom_system.xpt to the installer, v2

Sorry, wrong patch. Any idea how I can test this or who could review this?

Comment 10

[Josh Matthews [:jdm]]

Comment on attachment 694378 [details] [diff] [review]
Adding dom_system.xpt to the installer, v2

Roll the rice. Also, the commit message is wrong in just about every way possible :)

Comment 11

[(not currently active) Ted Mielczarek]

Comment on attachment 694378 [details] [diff] [review]
Adding dom_system.xpt to the installer, v2

Review of attachment 694378 [details] [diff] [review]:
-----------------------------------------------------------------

This is fine, but this only fixes Firefox for Android, which is not Gonk. Did you actually mean Gonk (which is the underpinnings of B2G), or are you just confused?

Comment 12

[David Teller [:Yoric] - still alive but not very active]

Attachment: Adding dom_system.xpt to the installer, v3

Sorry, wrong patch.

Comment 13

[David Teller [:Yoric] - still alive but not very active]

Try: https://tbpl.mozilla.org/?tree=Try&rev=20618a591248

Comment 14

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/integration/mozilla-inbound/rev/1ec805274a72

Comment 15

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/mozilla-central/rev/1ec805274a72

Comment 16

[[:fabrice] Fabrice Desré]

Comment on attachment 694436 [details] [diff] [review]
Adding dom_system.xpt to the installer, v3

[Approval Request Comment]
Bug caused by (feature/regressing bug #): blocks a blocker
User impact if declined: we need that for a better user experience with app updates
Testing completed: nothing neede
Risk to taking this patch (and alternatives if risky): none
String or UUID changes made by this patch: none

Comment 17

[[:fabrice] Fabrice Desré]

https://hg.mozilla.org/releases/mozilla-b2g18/rev/25c0cfad5b8a