Closed Bug 803219 Opened 7 years ago Closed 7 years ago

Fix interpreter type checks

Categories

(Core :: JavaScript Engine, defect)

defect
Not set

Tracking

()

RESOLVED FIXED
mozilla19

People

(Reporter: jandem, Assigned: jandem)

Details

Attachments

(1 file)

The interpreter used to call TypeCheckNextBytecode to check if the values pushed on the stack match the inferred types. Bug 799777 simplified the interpreter loop, but now this function is no longer called.

These checks caught tons of JIT and TI bugs, so we should bring them back.
Attached patch PatchSplinter Review
(I tested this patch by modifying JSOP_ADD to always push "undefined", with the patch applied it fails with an inference failure.)
Assignee: general → jdemooij
Status: NEW → ASSIGNED
Attachment #672902 - Flags: review?(terrence)
Comment on attachment 672902 [details] [diff] [review]
Patch

Review of attachment 672902 [details] [diff] [review]:
-----------------------------------------------------------------

Good catch!  I should have done a closer comparison when I pulled out all the threaded code blocks.
Attachment #672902 - Flags: review?(terrence) → review+
https://hg.mozilla.org/mozilla-central/rev/d692e3c39a17
Status: ASSIGNED → RESOLVED
Closed: 7 years ago
Flags: in-testsuite-
Resolution: --- → FIXED
Target Milestone: --- → mozilla19
You need to log in before you can comment on or make changes to this bug.