Closed
Bug 803219
Opened 14 years ago
Closed 14 years ago
Fix interpreter type checks
Categories
(Core :: JavaScript Engine, defect)
Core
JavaScript Engine
Tracking
()
RESOLVED
FIXED
mozilla19
People
(Reporter: jandem, Assigned: jandem)
Details
Attachments
(1 file)
|
1.62 KB,
patch
|
terrence
:
review+
|
Details | Diff | Splinter Review |
The interpreter used to call TypeCheckNextBytecode to check if the values pushed on the stack match the inferred types. Bug 799777 simplified the interpreter loop, but now this function is no longer called.
These checks caught tons of JIT and TI bugs, so we should bring them back.
|
Assignee | |
Comment 1•14 years ago
|
||
(I tested this patch by modifying JSOP_ADD to always push "undefined", with the patch applied it fails with an inference failure.)
|
||
Comment 2•14 years ago
|
||
Comment on attachment 672902 [details] [diff] [review]
Patch
Review of attachment 672902 [details] [diff] [review]:
-----------------------------------------------------------------
Good catch! I should have done a closer comparison when I pulled out all the threaded code blocks.
Attachment #672902 -
Flags: review?(terrence) → review+
|
|
Assignee | |
Comment 3•14 years ago
|
||
|
||
Comment 4•14 years ago
|
||
Status: ASSIGNED → RESOLVED
Closed: 14 years ago
Flags: in-testsuite-
Resolution: --- → FIXED
Target Milestone: --- → mozilla19
You need to log in
before you can comment on or make changes to this bug.
Description
•