803236 - build warnings for init list order of nsSTSHostEntry

Status: RESOLVED FIXED

(Core :: Security, defect)

Description

[Daniel Holbert [:dholbert]]

Reporting build warnings:
{
478.33 In file included from /mozilla/security/manager/boot/src/nsStrictTransportSecurityService.cpp:13:0:
478.34 /mozilla/security/manager/boot/src/nsStrictTransportSecurityService.h: In constructor 'nsSTSHostEntry::nsSTSHostEntry(const char*)':
478.34 Warning: -Wreorder in /mozilla/security/manager/boot/src/nsStrictTransportSecurityService.h: 'nsSTSHostEntry::mExpired' will be initialized after
478.34 /mozilla/security/manager/boot/src/nsStrictTransportSecurityService.h:66:10: warning: 'nsSTSHostEntry::mExpired' will be initialized after [-Wreorder]
478.34 Warning: -Wreorder in /mozilla/security/manager/boot/src/nsStrictTransportSecurityService.h:   'uint32_t nsSTSHostEntry::mStsPermission'
478.34 /mozilla/security/manager/boot/src/nsStrictTransportSecurityService.h:65:14: warning:   'uint32_t nsSTSHostEntry::mStsPermission' [-Wreorder]
478.34 Warning: -Wreorder in /mozilla/security/manager/boot/src/nsStrictTransportSecurityService.cpp:   when initialized here
478.34 /mozilla/security/manager/boot/src/nsStrictTransportSecurityService.cpp:49:1: warning:   when initialized here [-Wreorder]


478.34 In file included from /mozilla/security/manager/boot/src/nsStrictTransportSecurityService.cpp:13:0:
478.34 /mozilla/security/manager/boot/src/nsStrictTransportSecurityService.h: In copy constructor 'nsSTSHostEntry::nsSTSHostEntry(const nsSTSHostEntry&)':
478.34 Warning: -Wreorder in /mozilla/security/manager/boot/src/nsStrictTransportSecurityService.h: 'nsSTSHostEntry::mExpired' will be initialized after
478.34 /mozilla/security/manager/boot/src/nsStrictTransportSecurityService.h:66:10: warning: 'nsSTSHostEntry::mExpired' will be initialized after [-Wreorder]
478.34 Warning: -Wreorder in /mozilla/security/manager/boot/src/nsStrictTransportSecurityService.h:   'uint32_t nsSTSHostEntry::mStsPermission'
478.34 /mozilla/security/manager/boot/src/nsStrictTransportSecurityService.h:65:14: warning:   'uint32_t nsSTSHostEntry::mStsPermission' [-Wreorder]
478.34 Warning: -Wreorder in /mozilla/security/manager/boot/src/nsStrictTransportSecurityService.cpp:   when initialized here
478.34 /mozilla/security/manager/boot/src/nsStrictTransportSecurityService.cpp:58:1: warning:   when initialized here [-Wreorder]
}

The 2 nsSTSHostEntry() constructors just have their init lists out of order w.r.t. the .h file.   (mStsPermission should come before mExpired)

Comment 1

[Daniel Holbert [:dholbert]]

Attachment: fix (and mark directory as warning-free)

This fixes the build warnings, and marks the directory as warning-free, since this was the only warning in my local debug build. (so that any additional warnings introduced here will turn tinderbox red)

Comment 2

[Dana Keeler (she/her) (use needinfo) [:keeler] (on leave)]

Comment on attachment 672912 [details] [diff] [review]
fix (and mark directory as warning-free)

Review of attachment 672912 [details] [diff] [review]:
-----------------------------------------------------------------

Looks good. I'm not a PSM peer, so technically you need two more reviews, but I think if Brian (or another peer that has more time) has a quick look, that'll be fine.

Comment 3

[Daniel Holbert [:dholbert]]

Attachment: fix v2 (also marking security/manager/pki/src/ as warning-free)

Updated the patch to also mark the sibling-directory "pki/src" as warning-free, since it is, at least on my machine w/ gcc 4.7. Here's a TBPL run showing that this is fine there as well:
  https://tbpl.mozilla.org/?tree=Try&rev=041a50929ffe

(BTW: I tried marking /ssl/src as warning-free, too -- that's the only other directory within /security/manager that has .cpp files -- but that didn't work, because it has a few build warnings.)

Comment 4

[Brian Smith (:briansmith, :bsmith, use NEEDINFO?)]

Comment on attachment 672980 [details] [diff] [review]
fix v2 (also marking security/manager/pki/src/ as warning-free)

Review of attachment 672980 [details] [diff] [review]:
-----------------------------------------------------------------

Thanks for doing this. I will make ssl/ warnings-free too soon.

Comment 5

[Daniel Holbert [:dholbert]]

https://hg.mozilla.org/integration/mozilla-inbound/rev/c14d2bf709ca

Comment 6

[Ed Morley [:emorley]]

https://hg.mozilla.org/mozilla-central/rev/c14d2bf709ca