803287 - Don't use GStreamer (when enabled) for Ogg/WebM if builtin backends present

Status: RESOLVED FIXED

(Core :: Audio/Video, defect)

Description

[Chris Pearce [:cpearce (Not reading bugmail)]]

We decided over in bug 794282 to not use the GStreamer backend for Ogg/WebM if the builtin Ogg/WebM backends are present. This is because we've extensively tested our Ogg/WebM backends, whereas the GStreamer backend has had limited testing; with GStreamer enabled we get mochitest failures and timeouts, and even when we don't use GStreamer for Ogg/WebM we still get mochitest failures and a shutdown hang after the test run.

I'll include a pref to allow GStreamer to be preferred for Ogg/WebM, for adventurous types.

Comment 1

[Chris Pearce [:cpearce (Not reading bugmail)]]

Attachment: Patch v1: Prefer to use builtin media decoder backends over GStreamer for Ogg/WebM

* Prefer to use builtin media decoder backends over GStreamer for Ogg/WebM.
* Add pref media.prefer-gstreamer to change to prefer GStreamer over builtin decoders.
* Rename nsHTMLMediaElement::IsH264* methods to IsGStreamer* methods, since GStreamer isn't the only backend that'll provide H.264 support. I kept nsHTMLMediaElement::IsH264Type(), since that function is useful by itself.
* Renamed media.h264.enabled pref to media.gstreamer.enabled, since gstreamer isn't the only backend that'll provide H.264 support.
* Use nsHTMLMediaElement::Is{Ogg,WebM,GStreamerSupported}Type in nsContentUtils::FindInternalContentViewer(type), rather than iterating over the nsHTMLMediaElement::g{Ogg,WebM,H264}Types arrays (ideally we'll make those arrays private in future I think).

Comment 2

[Chris Pearce [:cpearce (Not reading bugmail)]]

(In reply to Chris Pearce (:cpearce) from comment #1)
> Created attachment 672969 [details] [diff] [review]
> Patch v1: Prefer to use builtin media decoder backends over GStreamer for
> Ogg/WebM

doublec: I know you're pretty busy at the moment, should we pass review here onto someone else?

Comment 3

[Chris Pearce [:cpearce (Not reading bugmail)]]

https://hg.mozilla.org/integration/mozilla-inbound/rev/3c2cdc5f53ae

Comment 4

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/mozilla-central/rev/3c2cdc5f53ae