Closed Bug 803306 Opened 8 years ago Closed 8 years ago

Named setters/creators incorrectly set an expando in addition to calling the setter

Categories

(Core :: DOM: Core & HTML, defect)

x86
macOS
defect
Not set
normal

Tracking

()

RESOLVED FIXED
mozilla19

People

(Reporter: bzbarsky, Assigned: bzbarsky)

References

Details

Attachments

(1 file)

Because there's a missing return, so we not only call the creator but also end up falling through to mozilla::dom::DOMProxyHandler::defineProperty which sets the expando.  This causes some test failures with the patch for bug 803129.
Whiteboard: [need review]
Attachment #672977 - Flags: review?(peterv) → review+
https://hg.mozilla.org/integration/mozilla-inbound/rev/6184b17f8abd
Flags: in-testsuite+
Whiteboard: [need review]
Target Milestone: --- → mozilla19
https://hg.mozilla.org/mozilla-central/rev/6184b17f8abd
Assignee: nobody → bzbarsky
Status: NEW → RESOLVED
Closed: 8 years ago
Resolution: --- → FIXED
Component: DOM → DOM: Core & HTML
You need to log in before you can comment on or make changes to this bug.