Closed
Bug 803306
Opened 12 years ago
Closed 12 years ago
Named setters/creators incorrectly set an expando in addition to calling the setter
Categories
(Core :: DOM: Core & HTML, defect)
Tracking
()
RESOLVED
FIXED
mozilla19
People
(Reporter: bzbarsky, Assigned: bzbarsky)
References
Details
Attachments
(1 file)
|
1.46 KB,
patch
|
peterv
:
review+
|
Details | Diff | Splinter Review |
Because there's a missing return, so we not only call the creator but also end up falling through to mozilla::dom::DOMProxyHandler::defineProperty which sets the expando. This causes some test failures with the patch for bug 803129.
|
Assignee | |
Comment 1•12 years ago
|
||
Attachment #672977 -
Flags: review?(peterv)
|
|
Assignee | |
Updated•12 years ago
|
Whiteboard: [need review]
|
||
Updated•12 years ago
|
Attachment #672977 -
Flags: review?(peterv) → review+
|
|
Assignee | |
Comment 2•12 years ago
|
||
Flags: in-testsuite+
Whiteboard: [need review]
Target Milestone: --- → mozilla19
|
||
Comment 3•12 years ago
|
||
Assignee: nobody → bzbarsky
Status: NEW → RESOLVED
Closed: 12 years ago
Resolution: --- → FIXED
|
||
Updated•6 years ago
|
Component: DOM → DOM: Core & HTML
You need to log in
before you can comment on or make changes to this bug.
Description
•