803327 - [AccessFu] No window is passed to Presenter.viewportChanged()

Status: RESOLVED FIXED

(Core :: Disability Access APIs, defect)

Comment 1

[Eitan Isaacson [:eeejay]]

Attachment: Provide window to viewportChanged in presenters

Comment 2

[David Bolter [:davidb] (NeedInfo me for attention)]

Comment on attachment 672993 [details] [diff] [review]
Provide window to viewportChanged in presenters

Review of attachment 672993 [details] [diff] [review]:
-----------------------------------------------------------------

::: accessible/src/jsat/EventManager.jsm
@@ -81,3 @@
>          this.present(
>            function(p) {
> -            return p.viewportChanged();;

Heh. I was confused by this yesterday.

Comment 3

[Eitan Isaacson [:eeejay]]

https://hg.mozilla.org/integration/mozilla-inbound/rev/114ea5032eb0

Comment 4

[Eitan Isaacson [:eeejay]]

Oops.. I thought the last comment was an r+, just noticed it is still not.

Comment 5

[David Bolter [:davidb] (NeedInfo me for attention)]

Comment on attachment 672993 [details] [diff] [review]
Provide window to viewportChanged in presenters

Review of attachment 672993 [details] [diff] [review]:
-----------------------------------------------------------------

(In reply to Eitan Isaacson [:eeejay] from comment #4)
> Oops.. I thought the last comment was an r+, just noticed it is still not.

I guess it is ok. Why is the variable still called "window"?

Comment 6

[David Bolter [:davidb] (NeedInfo me for attention)]

- still

Comment 7

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/mozilla-central/rev/114ea5032eb0

Comment 8

[Marco Zehe (:MarcoZ)]

Comment on attachment 672993 [details] [diff] [review]
Provide window to viewportChanged in presenters

[Approval Request Comment]
Bug caused by (feature/regressing bug #): Bug 791400
User impact if declined: Rectangle does not get updated once the page starts scrolling. Indication of accessibility focus broken.
Testing completed (on m-c, etc.): Yes.
Risk to taking this patch (and alternatives if risky): None.
String or UUID changes made by this patch: None.

Comment 9

[Eitan Isaacson [:eeejay]]

http://hg.mozilla.org/releases/mozilla-aurora/rev/168eaeaa0580