803330 - "ASSERTION: row count did not change by the amount suggested, check caller" with Page Info

Status: RESOLVED FIXED

(Firefox :: Page Info Window, defect)

Description

[Jesse Ruderman]

Attachment: testcase (see comment 0)

1. Load the testcase
2. ⌘I (open page info)
3. ⌘` (switch back to the browser window)
4. ⌘I (reset page info)

###!!! ASSERTION: row count did not change by the amount suggested, check caller: 'rowCount == mRowCount', file layout/xul/base/src/tree/src/nsTreeBodyFrame.cpp, line 1819

Not sure if this is a Page Info bug or a XUL tree bug.

Comment 1

[Jesse Ruderman]

Attachment: stack

Comment 2

[Dana Keeler (she/her) (use needinfo) [:keeler] (on leave)]

I can reproduce this by just opening the page info dialog - the page in question doesn't seem to matter.

Comment 3

[Dana Keeler (she/her) (use needinfo) [:keeler] (on leave)]

Attachment: bug 803330 - fix row count assertion failure in page info dialog

When calling rowCountChanged on an nsITreeBoxObject, the implementation assumes
that the row count has actually changed. pageInfoTreeView violated this
assumption in addRows by first calling rowCountChanged and then updating its row
count. This patch fixes the issue by using the power of decomposition. That is,
there's already a perfectly fine function called 'addRow' that can be called
once for each row being added.

Review commit: https://reviewboard.mozilla.org/r/64418/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/64418/

Comment 4

[Florian Quèze [:florian]]

Comment on attachment 8771168 [details]
bug 803330 - fix row count assertion failure in page info dialog

https://reviewboard.mozilla.org/r/64418/#review61872

I wonder if the rowCountChanged calls are likely to have a performance impact, but given that addRows is currently only used for meta tags, and media elements already call addRow once for each item, it's likely not going to matter.

Comment 5

[Dana Keeler (she/her) (use needinfo) [:keeler] (on leave)]

Thanks!

Comment 6

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/75f8e3a05ef8
fix row count assertion failure in page info dialog r=florian

Comment 7

[Carsten Book [:Tomcat]]

https://hg.mozilla.org/mozilla-central/rev/75f8e3a05ef8