Add support for dxr-mozilla-central so it does not appear as "?"

RESOLVED FIXED

Status

RESOLVED FIXED
6 years ago
4 years ago

People

(Reporter: emorley, Assigned: emorley)

Tracking

Dependency tree / graph

Details

Attachments

(1 attachment, 1 obsolete attachment)

(Assignee)

Description

6 years ago
Bug 802202 added support for showing unknown platforms/suites (is not yet in production).

Whilst testing the patch there I noticed we don't support dxr-mozilla-central.

Whilst we may not be too fussed about it - and can just hide it using the hidden builders list - we should still add support for it, so we don't get the "?" when using &noignore=1.

It's built on Linux64, so I guess we could put it on that row - though "Other" (which it is currently defaulting to) may actually be more appropriate.

Build log:
https://tbpl.mozilla.org/php/getParsedLog.php?id=16229815&tree=Firefox
(Assignee)

Updated

6 years ago
Blocks: 731256
(Assignee)

Comment 1

6 years ago
Created attachment 673217 [details] [diff] [review]
Patch v1

The dxr builds are opt and performed on Linux64, so this patch makes them display on the existing Linux64 opt row as "Dxr", with tooltip "DXR Indices Build".

Happy to adjust the tooltip/'Dxr' or put on an "Other" row instead of Linux64 opt, if deemed more suitable.
(Assignee)

Comment 2

6 years ago
Could you take a look at the strings in comment 1 and see if they are suitable? :-)
Eventually, I think we want DXR indexing to run on multiple platforms, so keeping it on Linux64 opt makes sense to me.

I think I'd prefer "DXR Index Build" instead of "DXR Indices Build".
(Assignee)

Comment 4

6 years ago
Created attachment 673290 [details] [diff] [review]
Patch v2

(In reply to Joshua Cranmer [:jcranmer] from comment #3)
> Eventually, I think we want DXR indexing to run on multiple platforms, so
> keeping it on Linux64 opt makes sense to me.
> 
> I think I'd prefer "DXR Index Build" instead of "DXR Indices Build".

Have s/Indices/Index/

Regarding other platforms, when we come to that point we'll need to update the buildername to include platform (on the buildbot side) and update TBPL appropriately - since it currently only specifies 'dxr-' and tree, but we can cross that bridge later :-)

(Will land this after the patches in bug 786314 land, so I don't have to rebase them all; also the DXR builds will need to stay hidden until they green up, due to bug 803530.)
Attachment #673217 - Attachment is obsolete: true
(Assignee)

Updated

6 years ago
Depends on: 805201
(Assignee)

Updated

6 years ago
Status: ASSIGNED → RESOLVED
Last Resolved: 6 years ago
Resolution: --- → FIXED
Product: Webtools → Tree Management
Product: Tree Management → Tree Management Graveyard
You need to log in before you can comment on or make changes to this bug.