803373 - [socorro-crashstats] Comments tab can't count

Status: VERIFIED FIXED

(Socorro :: Webapp, task)

Description

[Stephen Donner [:stephend] Not actively reading bugmail]

Attachment: Screenshot

STR:

1. Load http://crash-stats-new-dev.allizom.org/report/list?version=Firefox:17.0&query_search=signature&query_type=contains&reason_type=contains&date=2012-10-19&range_value=28&range_unit=days&hang_type=any&process_type=any&signature=js%3A%3AGetObjectParent%28JSObject*%29
2. Look at the Comments (2) tab

Expected:

Should be 24

Comment 1

[Robert Helmer [:rhelmer]]

r? https://github.com/mozilla/socorro-crashstats/pull/188

Comment 2

[Lonnen :lonnen]

The bugs tab also has an incorrect count. Should we be using .total instead of |count there as well?

Comment 3

[Robert Helmer [:rhelmer]]

(In reply to Chris Lonnen :lonnen from comment #2)
> The bugs tab also has an incorrect count. Should we be using .total instead
> of |count there as well?

yes (or "bugs.hits | count", but might as well let the mware do the work)

Comment 4

[[github robot]]

Commits pushed to master at https://github.com/mozilla/socorro-crashstats

https://github.com/mozilla/socorro-crashstats/commit/0e45df61bea8e82d3d1afc0940da90b158b2bef0
bug 803373 - fix comments count

https://github.com/mozilla/socorro-crashstats/commit/64382007f5d3f916cd5d4fe58bb9a1bdf9fb71af
Merge pull request #188 from rhelmer/bug803373-fix-comments-count

bug 803373 - fix comments count

Comment 5

[Stephen Donner [:stephend] Not actively reading bugmail]

Verified FIXED on http://crash-stats-new-dev.allizom.org/report/list?version=Firefox:17.0&query_search=signature&query_type=contains&reason_type=contains&date=2012-10-19&range_value=28&range_unit=days&hang_type=any&process_type=any&signature=js%3A%3AGetObjectParent%28JSObject*%29, 24 results when I tested.