Closed
Bug 803465
Opened 12 years ago
Closed 12 years ago
Iframe shouldn't override a sub document role
Categories
(Core :: Disability Access APIs, defect)
Core
Disability Access APIs
Tracking
()
RESOLVED
FIXED
mozilla19
People
(Reporter: surkov, Assigned: surkov)
References
(Blocks 1 open bug)
Details
Attachments
(1 file)
3.49 KB,
patch
|
davidb
:
review+
|
Details | Diff | Splinter Review |
We were asked to not propagate the role from iframe to sub document. Rich said: "The problem is that when you have an IFrame, the role attribute applied to the IFrame is applied to the child document contained within the IFrame. This creates two problems: 1. If the author applies a navigation landmark on the IFrame Firefox copies it over the role of the child document. We have a situation in our cloud based office suite where Firefox is doing this. 2. If the author has actually set a role on the child document contained within the IFrame and the author had applied a role to it (such as role="application") it will be overridden. This is very problematic as it breaks interoperability." "We discussed it today and we think it is a huge mistake to be overriding the roles a author sets in web content in the browser when mapping to the accessibility API." The behavior was introduced in bug 419416. Example and document link that could clarify the need to this behavior don't work anymore. I think it's reasonable to follow Rich's suggestion.
Attachment #673123 -
Flags: review?(dbolter)
Comment 1•12 years ago
|
||
Comment on attachment 673123 [details] [diff] [review] patch Review of attachment 673123 [details] [diff] [review]: ----------------------------------------------------------------- Aaron won't like this (I recall discussion from years ago) but I think this is the right thing to do as per comment 0.
Attachment #673123 -
Flags: review?(dbolter) → review+
Assignee | ||
Comment 2•12 years ago
|
||
(In reply to David Bolter [:davidb] from comment #1) > Aaron won't like this (I recall discussion from years ago) but I think this > is the right thing to do as per comment 0. I'd love to hear another point of view. Personally I don't have opinion this since I don't have valid usecases. We were asked to change it and arguments were reasonable so I meet them half-way.
Assignee | ||
Comment 3•12 years ago
|
||
http://hg.mozilla.org/integration/mozilla-inbound/rev/c127ae4496a3
Target Milestone: --- → mozilla19
Comment 4•12 years ago
|
||
https://hg.mozilla.org/mozilla-central/rev/c127ae4496a3
Status: ASSIGNED → RESOLVED
Closed: 12 years ago
Flags: in-testsuite-
Resolution: --- → FIXED
You need to log in
before you can comment on or make changes to this bug.
Description
•