803466 - TBPL logs don't show pymake failures

Status: RESOLVED INCOMPLETE

(Tree Management Graveyard :: TBPL, defect)

Description

[Mike Hommey [:glandium]]

See https://tbpl.mozilla.org/php/getParsedLog.php?id=16257848&tree=Try&full=1 for example. There are many pymake failure messages in there, in the form "path:line: command 'command' failed, return code n" , and none are highlighted, which makes it very hard to find errors in pymake builds.

Relatedly, when failures don't happen in the build part, usually, errors are not highlighted either, and the best bet is to look for the "Finished xxxxxx failed" to know what part of the tinderbox script failed. It might be helpful to highlight those as well, or at the very least, do so in the absence of any other error highlight.

Comment 1

[Ed Morley [:emorley]]

What should we be parsing on here?

Current regex is:
https://hg.mozilla.org/users/mstange_themasta.com/tinderboxpushlog/file/43b5054776ba/php/inc/GeneralErrorFilter.php#l25

Comment 2

[Mike Hommey [:glandium]]

I guess, something like:
/command '.*' failed, return code \d+$/

And
/========= Finished .* failed/

Comment 3

[Ed Morley [:emorley]]

TBPL has been EOLed (bug 1054977).

Comment 4

[Mike Hommey [:glandium]]

More importantly, pymake has been EOLed. Because if it hadn't been, that'd likely still be a relevant bug against treeherder's log viewer.