Closed
Bug 80347
Opened 24 years ago
Closed 24 years ago
.doc attachment open as garbage if there is a supported attachment with it
Categories
(MailNews Core :: Backend, defect, P2)
MailNews Core
Backend
Tracking
(Not tracked)
VERIFIED
FIXED
mozilla0.9.2
People
(Reporter: esther, Assigned: mscott)
References
Details
(Whiteboard: [nsbeta1+][PDT+] Have Fix)
Attachments
(2 files)
991 bytes,
patch
|
Details | Diff | Splinter Review | |
1.62 KB,
patch
|
Details | Diff | Splinter Review |
Using build 2001-05-11 on windows, if you send a message with a .doc file
attached and anther inline supported attachment (.gif or jpg) the .doc file will
open up and display garbage. If the .doc file is the only file it opens OK.
Not sure if this bug is related to bug 80332.
1. Send yourself a message with a .doc file
2. Open the messge and open the attachment = .doc file displays ok
3. Sent yourself a message with the same .doc file and a .jpg or .gif file
4. Open the message and opne the .doc attachment = .doc file opens and
displays garbage.
We had a bug similiar to this that was fixed and verified but in that one the
.doc file always opened displaying garbage.
fyi...Old bug for word attachments being corrupt is 73093, which was fixed and
verified.
marking nsbeta1+, attachments need to be displayed correctly. Also note: the
.jpg and .gif files don't display when opend in a browser window with this
mixture of attachments
Comment 4•24 years ago
|
||
marking nsbeta1+ and moving to 0.9.2. If somehow there's time in 0.9.1, this
sounds like a good one to fix.
Priority: -- → P2
Whiteboard: [nsbeta1+]
Target Milestone: --- → mozilla0.9.2
Assignee | ||
Comment 5•24 years ago
|
||
Assignee | ||
Comment 6•24 years ago
|
||
I've posted a patch which shows why we can't open the doc attachment if there is
an inlined attachment with the message. This patch can't be checked in, it's
wrong but it demonstrates what is going on. I need to sit down with David
tomorrow to learn more about our imap body shell structure.
David, if I send myself a message with a .doc and a .jpeg (small jpeg), we
initially generate a body structure for the message. The jpeg gets a body part
#. In the imap log, I can then see us fetch just the image (since it's inline).
However, after fetching the image we then end up fetching the entire message and
extracting the image. That's because in ProcessSelectedStateURL we explicitly
say, if the url is of type ?part= then don't use our body structure. (around
line 1840). So we fall back to fetching the entire message by chunks.
If I force us to use the body structure we still fetch the image again (which we
shouldn't since the log shows me that we already fetched the image part) but at
least we don't fetch the entire message.
This hacky little patch show how removing the constraint of not using the body
shell if the url contains ?part= allows things to start working. but there's
still an extra fetch of the image.
Maybe we can sit down together tomorrow and look at this.
Status: NEW → ASSIGNED
Comment 7•24 years ago
|
||
Scott, we should have hit the code above, around line 1785:
// A single message ID
// First, let's see if we're requesting a specific MIME part
char *imappart = nsnull;
m_runningUrl->GetImapPartToFetch(&imappart);
if (imappart)
Is it possible GetImappartToFetch isn't returning the part?
Assignee | ||
Comment 8•24 years ago
|
||
Hey David, GetImappartToFetch only works for =section and ?section=. The url we
are getting is a ?part=. Don't ask me what the difference is =). But
GetImapPartToFetch ignores part= stuff. I'll try to tweak it to make it work for
part= too and see what I get.
Assignee | ||
Comment 9•24 years ago
|
||
Assignee | ||
Comment 10•24 years ago
|
||
I wonder if this is considered a beta stopper or not? cc'ing putterman
Comment 11•24 years ago
|
||
This would be great to fix for beta if you feel confident about your patch.
Assignee | ||
Updated•24 years ago
|
Whiteboard: [nsbeta1+] → [nsbeta1+] Have Fix
Comment 12•24 years ago
|
||
adding PDT+. please check in to the trunk as soon as possible.
Whiteboard: [nsbeta1+] Have Fix → [nsbeta1+][PDT+] Have Fix
Comment 13•24 years ago
|
||
r/sr = bienvenu - I found my test messages folder - do you want me to
send/forward them to you or try them myself? They mostly have embedded images
but there are a few other kinds of messages.
Assignee | ||
Comment 14•24 years ago
|
||
yeah that'd be great if you could send them to me. thanks david.
Comment 15•24 years ago
|
||
r=naving
Comment 16•24 years ago
|
||
a= asa@mozilla.org for checkin to the trunk.
(on behalf of drivers)
Assignee | ||
Comment 17•24 years ago
|
||
fix checked in.
Status: ASSIGNED → RESOLVED
Closed: 24 years ago
Resolution: --- → FIXED
Reporter | ||
Comment 18•24 years ago
|
||
Using build 2001-06-29 on win, mac and linux this is fixed. verified.
Status: RESOLVED → VERIFIED
Updated•20 years ago
|
Product: MailNews → Core
Updated•16 years ago
|
Product: Core → MailNews Core
You need to log in
before you can comment on or make changes to this bug.
Description
•