803475 - [b2g-bluetooth] Failed to transfer audio back to bluetooth headset while in a phone call

Status: RESOLVED FIXED

(Core :: DOM: Device Interfaces, defect)

Description

[Gina Yeh [:gyeh] [:ginayeh]]

When we connect with a bluetooth headset, Sco will be created while there's a phone call, and user can initiate audio transfer to close Sco socket. At this time, the audio route should be set back to headphone.

However, during the phone call, if user want to make the audio transfer again (which means set audio route to back Sco), we don't have listen socket and we can't accomplish the request.

Repro:
- Connect to a bluetooth headset
- Make a phone call
- Initiate audio transfer and set audio route to headphone (some bluetooth devices support this feature)
- Initiate audio transfer and set audio route back to bluetooth headset

Expected Behaviour:
- Create a Sco socket
- Should hear sounds from bluetooth headset

Actual Behaviour:
- Doesn't create a Sco socket and failed to make the audio transfer

Comment 1

[Gina Yeh [:gyeh] [:ginayeh]]

Attachment: Patch 1(v1): Add Listen() in BluetoothScoManager

Comment 2

[Kyle Machulis [:qdot] [:kmachulis] (INACTIVE)]

Comment on attachment 674578 [details] [diff] [review]
Patch 1(v1): Add Listen() in BluetoothScoManager

Review of attachment 674578 [details] [diff] [review]:
-----------------------------------------------------------------

Failing for same reasons as Bug 804436.

::: dom/bluetooth/linux/BluetoothDBusService.cpp
@@ +723,5 @@
>    {
> +    BluetoothHfpManager* hfp = BluetoothHfpManager::Get();
> +    if (hfp) {
> +      hfp->Listen();
> +    }

nit: Might want to warn on these failing?

Comment 3

[Gina Yeh [:gyeh] [:ginayeh]]

Attachment: Patch 1(v2): Add Listen() in BluetoothScoManager

Fixed as comments and also based on Bug 804436 patch 0.

Comment 4

[Kyle Machulis [:qdot] [:kmachulis] (INACTIVE)]

Comment on attachment 674978 [details] [diff] [review]
Patch 1(v2): Add Listen() in BluetoothScoManager

Review of attachment 674978 [details] [diff] [review]:
-----------------------------------------------------------------

I think you uploaded the wrong patch? This looks like the Hfp patch.

Comment 5

[Gina Yeh [:gyeh] [:ginayeh]]

Attachment: Patch 1(v3): Add Listen() in BluetoothScoManager

Oops! Please check the new one (v3), thanks.

Comment 6

[Gina Yeh [:gyeh] [:ginayeh]]

Attachment: Patch 1: Add Listen() in BluetoothScoManager, r=qdot

Comment 7

[Gina Yeh [:gyeh] [:ginayeh]]

try server: 
https://tbpl.mozilla.org/?tree=Try&rev=10dfe59dc433
https://tbpl.mozilla.org/?tree=Try&rev=6b22103a1603

Comment 8

[Eric Chou [:ericchou] [:echou]]

https://hg.mozilla.org/integration/mozilla-inbound/rev/1cd611b97178

Comment 9

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/mozilla-central/rev/1cd611b97178

Comment 10

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/releases/mozilla-aurora/rev/af799b3ec743