803520 - Don't use JSCList for JSRuntime::contextList

Status: RESOLVED FIXED

(Core :: JavaScript Engine, defect)

Description

[:Ms2ger (he/him; ⌚ UTC+1/+2)]

Attachment: Patch v1

Comment 1

[Jeff Walden [:Waldo]]

Comment on attachment 673214 [details] [diff] [review]
Patch v1

Review of attachment 673214 [details] [diff] [review]:
-----------------------------------------------------------------

::: js/src/jsapi.cpp
@@ +972,5 @@
>  #endif
>  
>  #ifdef DEBUG
>      /* Don't hurt everyone in leaky ol' Mozilla with a fatal JS_ASSERT! */
> +    if (!contextList.isEmpty()) {

This probably reads better as hasContexts().

::: js/src/jscntxt.h
@@ +1215,5 @@
>  
>  } /* namespace js */
>  
>  struct JSContext : js::ContextFriendFields
> +                 , public mozilla::LinkedListElement<JSContext>

struct JSContext
  : js::ContextFriendFields,
    public mozilla::LinkedListElement<JSContext>

Comment 2

[:Ms2ger (he/him; ⌚ UTC+1/+2)]

https://hg.mozilla.org/mozilla-central/rev/8f56f3f96a79