803549 - [System] Replace default Android FOTA animation with our own for FXOS

Status: RESOLVED FIXED

(Firefox OS Graveyard :: General, defect, P3)

Description

[Peter La]

Create images to replace animation frames in stock FOTA animation.  Work with Michael Wu to get this integrated.

Comment 1

[Peter La]

Attachment: FOTA Animation Assets

Comment 2

[Peter La]

Marshall to take?

Comment 3

[Peter La]

Attachment: New FOTA Animation Assets + Animated GIF Reference

Hi Marshall,

Here are the new FOTA animation assets.  Included in the zip is an animated gif to show you how it looks.  It's very similar but I think better.  The progress bars have also been moved up and shortened, so I saved them out with padding at the bottom.  Hopefully the system uses them properly.  Otherwise, let me know and I can save them out again differently.

Thanks!

Comment 5

[Dietrich Ayala (:dietrich)]

Hi Marshall, do you have an ETA for fixing this?

Comment 6

[Marshall Culpepper [:marshall_law]]

This will probably require OEM support since we don't own the recovery image. I can build it locally to show off in a demo, but I'm not sure we want to go flashing people's recovery partition with the AOSP vanilla recovery image.

CCing cjones and mwu for their thoughts..

Comment 7

[Chris Jones [:cjones] inactive; ni?/f?/r? if you need me]

m1, our work here is done, but we don't build our recovery image so it's not crystal clear how best to get this downstream.

What build hack would you recommend for making thewse assets available for injecting into vendor builds?

Comment 8

[Chris Jones [:cjones] inactive; ni?/f?/r? if you need me]

(In reply to Marshall Culpepper [:marshall_law] from comment #6)
> but I'm not sure we
> want to go flashing people's recovery partition with the AOSP vanilla
> recovery image.

I would be fine with integrating this into our default testdriver builds, except that there was a concern from branding folks about doing that.  So no need.

Comment 9

[Michael Vines [:m1] [:evilmachines]]

(In reply to Chris Jones [:cjones] [:warhammer] from comment #7)
> What build hack would you recommend for making thewse assets available for
> injecting into vendor builds?

Looked at it quickly and doesn't look too painful (relatively, we are talking about modifying make here...).  *Might* be able to even get away with just some strategic macro overrides.  Just land the new assets somewhere nice and I'll figure out how to get build/core/Makefile to submit from there.

Comment 10

[Marshall Culpepper [:marshall_law]]

I've built a new recovery package for unagi, and added instructions on how to install the package for testing. Contact me for links

Comment 11

[Chris Jones [:cjones] inactive; ni?/f?/r? if you need me]

Marshall, let's stick this in librecovery for now.  That's not an ideal solution because that code isn't brand-specific, technically, but it means that downstreams can override all this stuff in one shot.

Comment 12

[Michael Vines [:m1] [:evilmachines]]

Did the new assets land in librecovery?  I don't see 'em in https://github.com/mozilla-b2g/librecovery/commits/master.  Wrong librecovery?

Comment 13

[Chris Jones [:cjones] inactive; ni?/f?/r? if you need me]

Marshall?

Comment 14

[Marshall Culpepper [:marshall_law]]

Sorry guys, didn't see the requests to push the assets.

I've made a pull request in our android-device-unagi repo that enables our recovery changes and has the new assets:

https://github.com/mozilla-b2g/android-device-unagi/pull/11

Comment 15

[Michael Vines [:m1] [:evilmachines]]

Oh, throwing the assets in that git project doesn't help because it's not actually used in the final product.   librecovery seems nice or maybe even gaia?

Comment 16

[Michael Wu [:mwu]]

(In reply to Michael Vines [:m1] from comment #15)
> Oh, throwing the assets in that git project doesn't help because it's not
> actually used in the final product.   librecovery seems nice or maybe even
> gaia?

Part of the problem is that the build system is hardcoded to look for recovery image assets in the device directory. Maybe we can stick the images in librecovery and have devices symlink their recovery/res directory?

We can also stick the recovery_ui_fxos.c file in there but it seems like most vendors end up customizing this file.

Comment 17

[Michael Vines [:m1] [:evilmachines]]

Yeah, symlink or something like that is what I was thinking of for our builds.

Comment 18

[Michael Vines [:m1] [:evilmachines]]

I see that this will landed in android-device-unagi regardless.  Will you also land this someplace else so that it's usable in the v1 product without a fork?

Comment 19

[Michael Wu [:mwu]]

Marshall, do you mind moving recovery/res to librecovery?

Comment 20

[Marshall Culpepper [:marshall_law]]

Hey guys, sorry for the confusion.

I've pushed the resources to librecovery, and I'll open a new pull request to make android-device-unagi use a symlink

Comment 21

[Gervase Markham [:gerv]]

:marshall_law: so is this bug supposed to be fixed, or not? Is there further work? I ask because "Reset Phone" also brings up an Android, and I'm wondering if this fix will also fix that.

Gerv