Consider reversing the order of JSSLOT_PROXY_HANDLER and JSSLOT_PROXY_PRIVATE

RESOLVED FIXED in mozilla20

Status

()

Core
JavaScript Engine
RESOLVED FIXED
6 years ago
6 years ago

People

(Reporter: bz, Assigned: bz)

Tracking

unspecified
mozilla20
x86
Mac OS X
Points:
---
Bug Flags:
in-testsuite -

Firefox Tracking Flags

(Not tracked)

Details

Attachments

(1 attachment)

The win here would be that slot 0 would be up for grabs on both proxies and non-proxies, so someone who needs to have a mix of the two with a single slot of important info could use slot 0 for both.  This would let us get rid of some complexity in DOM binding code, and should make it easier to do jitcode that has to work on both DOM proxies and regular DOM objects.
Created attachment 687795 [details] [diff] [review]
Reverse the order of JSSLOT_PROXY_HANDLER and JSSLOT_PROXY_PRIVATE.
Attachment #687795 - Flags: review?(jwalden+bmo)
Whiteboard: [need review]

Updated

6 years ago
Attachment #687795 - Flags: review?(jwalden+bmo) → review+
Thanks!

https://hg.mozilla.org/integration/mozilla-inbound/rev/0e57f4245071
Assignee: general → bzbarsky
Flags: in-testsuite-
Whiteboard: [need review]
Target Milestone: --- → mozilla20

Comment 3

6 years ago
https://hg.mozilla.org/mozilla-central/rev/0e57f4245071
Status: NEW → RESOLVED
Last Resolved: 6 years ago
Resolution: --- → FIXED
You need to log in before you can comment on or make changes to this bug.