803638 - [AccessFu] Print more useful exception error outputs

Status: RESOLVED FIXED

(Core :: Disability Access APIs, defect)

Description

[Eitan Isaacson [:eeejay]]

We do a lot of Logger.error(exception) calls. Instead we should have a Logger.logException, which would provide a file, line number and optionally a stack.

Comment 1

[David Bolter [:davidb] (NeedInfo me for attention)]

+1

Comment 2

[Eitan Isaacson [:eeejay]]

Attachment: introduce logException

Comment 3

[David Bolter [:davidb] (NeedInfo me for attention)]

Comment on attachment 673341 [details] [diff] [review]
introduce logException

Review of attachment 673341 [details] [diff] [review]:
-----------------------------------------------------------------

Fine with me.

Comment 4

[Eitan Isaacson [:eeejay]]

https://hg.mozilla.org/integration/mozilla-inbound/rev/b2f24b1dc786

Comment 5

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/mozilla-central/rev/b2f24b1dc786

Comment 6

[Marco Zehe (:MarcoZ)]

Comment on attachment 673341 [details] [diff] [review]
introduce logException

[Approval Request Comment]
Bug caused by (feature/regressing bug #): Initial implementation of AccessFu logging.
User impact if declined: None, but if users send in exceptions, this would help us more easily identify potential problem areas.
Testing completed (on m-c, etc.): Yes.
Risk to taking this patch (and alternatives if risky): None.
String or UUID changes made by this patch: None.

Comment 7

[bhavana bajaj [:bajaj]]

Comment on attachment 673341 [details] [diff] [review]
introduce logException

Approving for aurora as its low risk and logging related

Comment 8

[Eitan Isaacson [:eeejay]]

http://hg.mozilla.org/releases/mozilla-aurora/rev/fb5e3b5b440b