Closed Bug 803641 Opened 7 years ago Closed 7 years ago

TestTArray.cpp:741:35: warning: comparison between signed and unsigned integer expressions [-Wsign-compare]

Categories

(Core :: XPCOM, defect)

x86_64
Linux
defect
Not set

Tracking

()

RESOLVED FIXED
mozilla19

People

(Reporter: dholbert, Assigned: dholbert)

References

(Blocks 1 open bug)

Details

Attachments

(1 file)

Reporting build warnings in TestTArray:

/mozilla/xpcom/tests/TestTArray.cpp: In function 'bool TestTArray::test_swap()':
/mozilla/xpcom/tests/TestTArray.cpp: comparison between signed and unsigned integer expressions
/mozilla/xpcom/tests/TestTArray.cpp:741:35: warning: comparison between signed and unsigned integer expressions [-Wsign-compare]
/mozilla/xpcom/tests/TestTArray.cpp: comparison between signed and unsigned integer expressions
/mozilla/xpcom/tests/TestTArray.cpp:742:35: warning: comparison between signed and unsigned integer expressions [-Wsign-compare]


These are the only build warnings I hit in the /xpcom/tests directory, so with these fixed, we can label the directory as FAIL_ON_WARNINGS. (assuming there isn't some other latent opt-only warning that I'm not hitting locally or something)
(This is from code added to the test in bug 687722, FWIW)
Blocks: 687722
Attached patch fixSplinter Review
Attachment #673345 - Flags: review?(justin.lebar+bug)
Attachment #673345 - Flags: review?(justin.lebar+bug) → review+
Landed, without the FAIL_ON_WARNINGS tweak:
  https://hg.mozilla.org/integration/mozilla-inbound/rev/fcc8dc83fa78


I removed the FAIL_ON_WARNINGS tweak because TryServer hit a clang-specific warning in a different file in that directory:
 https://tbpl.mozilla.org/php/getParsedLog.php?id=16275787&tree=Try

I'll file another bug on that outstanding warning in a bit. (hopefully _that_ bug can label the directory FAIL_ON_WARNINGS).
Try run for 652d065a6c18 is complete.
Detailed breakdown of the results available here:
    https://tbpl.mozilla.org/?tree=Try&rev=652d065a6c18
Results (out of 16 total builds):
    success: 14
    failure: 2
Builds (or logs if builds failed) available at:
http://ftp.mozilla.org/pub/mozilla.org/firefox/try-builds/dholbert@mozilla.com-652d065a6c18
https://hg.mozilla.org/mozilla-central/rev/fcc8dc83fa78
Status: ASSIGNED → RESOLVED
Closed: 7 years ago
Flags: in-testsuite-
Resolution: --- → FIXED
Target Milestone: --- → mozilla19
You need to log in before you can comment on or make changes to this bug.