803641 - TestTArray.cpp:741:35: warning: comparison between signed and unsigned integer expressions [-Wsign-compare]

Status: RESOLVED FIXED

(Core :: XPCOM, defect)

Description

[Daniel Holbert [:dholbert]]

Reporting build warnings in TestTArray:

/mozilla/xpcom/tests/TestTArray.cpp: In function 'bool TestTArray::test_swap()':
/mozilla/xpcom/tests/TestTArray.cpp: comparison between signed and unsigned integer expressions
/mozilla/xpcom/tests/TestTArray.cpp:741:35: warning: comparison between signed and unsigned integer expressions [-Wsign-compare]
/mozilla/xpcom/tests/TestTArray.cpp: comparison between signed and unsigned integer expressions
/mozilla/xpcom/tests/TestTArray.cpp:742:35: warning: comparison between signed and unsigned integer expressions [-Wsign-compare]


These are the only build warnings I hit in the /xpcom/tests directory, so with these fixed, we can label the directory as FAIL_ON_WARNINGS. (assuming there isn't some other latent opt-only warning that I'm not hitting locally or something)

Comment 1

[Daniel Holbert [:dholbert]]

(This is from code added to the test in bug 687722, FWIW)

Comment 2

[Daniel Holbert [:dholbert]]

Attachment: fix

Comment 3

[Daniel Holbert [:dholbert]]

Landed, without the FAIL_ON_WARNINGS tweak:
  https://hg.mozilla.org/integration/mozilla-inbound/rev/fcc8dc83fa78


I removed the FAIL_ON_WARNINGS tweak because TryServer hit a clang-specific warning in a different file in that directory:
 https://tbpl.mozilla.org/php/getParsedLog.php?id=16275787&tree=Try

I'll file another bug on that outstanding warning in a bit. (hopefully _that_ bug can label the directory FAIL_ON_WARNINGS).

Comment 4

[Mozilla RelEng Bot]

Try run for 652d065a6c18 is complete.
Detailed breakdown of the results available here:
    https://tbpl.mozilla.org/?tree=Try&rev=652d065a6c18
Results (out of 16 total builds):
    success: 14
    failure: 2
Builds (or logs if builds failed) available at:
http://ftp.mozilla.org/pub/mozilla.org/firefox/try-builds/[e-mail]-652d065a6c18

Comment 5

[(Out Sep 17-23) Ryan VanderMeulen]

https://hg.mozilla.org/mozilla-central/rev/fcc8dc83fa78