Closed Bug 803654 Opened 7 years ago Closed 7 years ago

Import mock into virtualenv

Categories

(Firefox Build System :: General, defect)

defect
Not set

Tracking

(Not tracked)

RESOLVED FIXED
mozilla19

People

(Reporter: ted, Assigned: ted)

References

Details

Attachments

(1 file)

I'd like to use the mock module for Python unittests. This patch imports mock-1.0.0 into the tree and puts it in the virtualenv.

Related: mock is apparently the core module "unittest.mock" in Python 3.3, which is neat. If we ever switch to requiring Python 3 we get this for free.
Attachment #673359 - Flags: review?(jhammel)
Comment on attachment 673359 [details] [diff] [review]
Import mock into virtualenv

I didn't read the whole patch, but assuming this is just a straight copy of the canonical module and addition to virtualenv/packages, lgtm
Attachment #673359 - Flags: review?(jhammel) → review+
That's exactly what it is. I untarred the 1.0.0 package from Pypi into the python/ dir, and updated build/virtualenv/packages.txt. (Sorry, should have mentioned that in my comment.)
Blocks: 774780
https://hg.mozilla.org/mozilla-central/rev/5981ff9d3f45
Status: NEW → RESOLVED
Closed: 7 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla19
It seems like a bit of generated junk like python/mock-1.0.0/html/.doctrees/*
was added. Intentional?
No, but if it's not hurting anything I'm not particularly worried about it.
Product: Core → Firefox Build System
You need to log in before you can comment on or make changes to this bug.