Import mock into virtualenv

RESOLVED FIXED in mozilla19

Status

()

Core
Build Config
RESOLVED FIXED
5 years ago
5 years ago

People

(Reporter: ted, Assigned: ted)

Tracking

unspecified
mozilla19
Points:
---

Firefox Tracking Flags

(Not tracked)

Details

Attachments

(1 attachment)

(Assignee)

Description

5 years ago
I'd like to use the mock module for Python unittests. This patch imports mock-1.0.0 into the tree and puts it in the virtualenv.

Related: mock is apparently the core module "unittest.mock" in Python 3.3, which is neat. If we ever switch to requiring Python 3 we get this for free.
(Assignee)

Comment 1

5 years ago
Created attachment 673359 [details] [diff] [review]
Import mock into virtualenv
Attachment #673359 - Flags: review?(jhammel)

Comment 2

5 years ago
Comment on attachment 673359 [details] [diff] [review]
Import mock into virtualenv

I didn't read the whole patch, but assuming this is just a straight copy of the canonical module and addition to virtualenv/packages, lgtm
Attachment #673359 - Flags: review?(jhammel) → review+
(Assignee)

Comment 3

5 years ago
That's exactly what it is. I untarred the 1.0.0 package from Pypi into the python/ dir, and updated build/virtualenv/packages.txt. (Sorry, should have mentioned that in my comment.)
(Assignee)

Comment 4

5 years ago
https://hg.mozilla.org/integration/mozilla-inbound/rev/5981ff9d3f45
(Assignee)

Updated

5 years ago
Blocks: 774780
https://hg.mozilla.org/mozilla-central/rev/5981ff9d3f45
Status: NEW → RESOLVED
Last Resolved: 5 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla19

Comment 6

5 years ago
It seems like a bit of generated junk like python/mock-1.0.0/html/.doctrees/*
was added. Intentional?
(Assignee)

Comment 7

5 years ago
No, but if it's not hurting anything I'm not particularly worried about it.
You need to log in before you can comment on or make changes to this bug.