803661 - Can't save from the view source window

Status: VERIFIED FIXED

(Toolkit :: View Source, defect)

Description

[[e-mail]]

As of bug 795065, attempting to save from the view source window throws a JavaScript ReferenceError: gDocument is not defined.

Comment 1

[[e-mail]]

Attachment: Proposed patch

Comment 2

[[e-mail]]

https://hg.mozilla.org/integration/mozilla-inbound/rev/561d6a3c4d7b

Comment 3

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/mozilla-central/rev/561d6a3c4d7b

Any way to test this?

Comment 4

[[e-mail]]

Comment on attachment 673379 [details] [diff] [review]
Proposed patch

[Approval Request Comment]
Bug caused by (feature/regressing bug #): 795065
User impact if declined: Minor, need to save file from browser (assuming source window was opened from the browser; Error Console, DOM Inspector and other addons might also be capable of opening source windows).
Testing completed (on m-c, etc.): 
Risk to taking this patch (and alternatives if risky): Low, code path is only used for saving from the view source window.
String or UUID changes made by this patch: None

Comment 5

[bhavana bajaj [:bajaj]]

(In reply to [e-mail] from comment #4)
> Comment on attachment 673379 [details] [diff] [review]
> Proposed patch
> 
> [Approval Request Comment]
> Bug caused by (feature/regressing bug #): 795065
> User impact if declined: Minor, need to save file from browser (assuming
> source window was opened from the browser; Error Console, DOM Inspector and
> other addons might also be capable of opening source windows).
> Testing completed (on m-c, etc.): 
> Risk to taking this patch (and alternatives if risky): Low, code path is
> only used for saving from the view source window.
> String or UUID changes made by this patch: None

Neil , How about "Testing completed (on m-c, etc.): " ? Was there any specific testing done to verify this ?

Comment 6

[bhavana bajaj [:bajaj]]

Adding qawanted to do a quick check on this ..

Comment 7

[juan becerra [:juanb]]

I spot checked this by opening several types of pages, html, scripts, pdfs, and then opening the view source window, selecting all and saving as. Then opening the saved documents and making sure they opened.

Comment 8

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/releases/mozilla-aurora/rev/5d1bc358a781

Comment 9

[Mihai Morar, (:MihaiMorar)]

(In reply to [e-mail] from comment #0)
> As of bug 795065, attempting to save from the view source window throws a
> JavaScript ReferenceError: gDocument is not defined.

Can you attach the link you got this issue please ? Because I did different kinds of exploratory on FF 18b6 and Nightly (19/10/2012) but they didn't help a lot without knowing the root cause.

Comment 10

[Mihai Morar, (:MihaiMorar)]

I confirm the fix is verified on FF 20b5:

Mozilla/5.0 (Windows NT 6.1; WOW64; rv:20.0) Gecko/20100101 Firefox/20.0(20130313170052)

Mozilla/5.0 (X11; Linux i686; rv:20.0) Gecko/20100101 Firefox/20.0(20130313170052)

Mozilla/5.0 (Macintosh; Intel Mac OS X 10.7; rv:20.0) Gecko/20100101 Firefox/20.0(20130313170052)