803741 - Add UA override for dailymotion.com for B2G

Status: VERIFIED FIXED

(Firefox OS Graveyard :: Gaia, defect, P2)

Description

[Tony Chung [:tchung]]

touch.dailymotion.com is mobile optimized for Fennec UA today.  lets do the same for the b2g UA:

Mozilla/5.0 (Mobile; rv:12.0) Gecko/12.0 Firefox/12.0

Currently on 10-19-2012 build, it shows the desktop site: www.dailymotion.com

Comment 2

[Jonas Sicking (:sicking) No longer reading bugmail consistently]

Oops, too quick fingers.

Comment 3

[Tony Chung [:tchung]]

resetting blocker flag

Comment 4

[Tony Chung [:tchung]]

Oh yeah, my justification for blocking+ is that touch.dailymotion.com falls back video content to h.264 on Fennec.   We need the same for b2g.

Comment 5

[Jason Smith [:jsmith]]

(In reply to Tony Chung [:tchung] from comment #4)
> Oh yeah, my justification for blocking+ is that touch.dailymotion.com falls
> back video content to h.264 on Fennec.   We need the same for b2g.

If we don't fix this, how well does the site operate? Is it a top site in any locales we are tracking?

Comment 6

[Gervase Markham [:gerv]]

This is the same bug as 803742...

We want one bug for "contact DailyMotion", and one bug for "add a UA override". We seem to have two of the latter, and none of the former.

https://wiki.mozilla.org/Evangelism/UA_Override_List_Policy is how this should work. :-)

Gerv

Comment 7

[Dão Gottwald [:dao]]

Bug 803742 is a tech evangelism bug.

Comment 8

[Andrew Overholt [:overholt]]

High enough alexa ranking to justify fixing.

Comment 9

[Alex Keybl [:akeybl]]

Milestoning for C2 (deadline of 12/10), as this meets the criteria of "known P2 bugs found before or during C1".

Comment 10

[Benoit Jacob [:bjacob] (mostly away)]

I have a couple question. My understanding is I should do roughly the same as

  https://github.com/mozilla-b2g/gaia/pull/6435/files

but for dailymotion.com. This patch does:

+pref("general.useragent.override.yelp.com", "\(Mobile#(Android; Mobile");

I need to know what the second string here, "\(Mobile#(Android; Mobile", really does (what syntax is that) and how I adapt it to do the UA string overriding asked for in comment 0 --- is the patch as simple as

+pref("general.useragent.override.dailymotion.com", "\(Mobile#(Android; Mobile");

?

Comment 11

[Benoit Jacob [:bjacob] (mostly away)]

Ah, got it:

http://mxr.mozilla.org/mozilla-central/source/netwerk/protocol/http/UserAgentOverrides.jsm#74

So this was just about replacing "Mobile" by "Android; Mobile" in the UA string.

Is this what you want done here as well for dailymotion?

Comment 12

[Gervase Markham [:gerv]]

Can you also add a comment to that block of prefs explaining the format? :-)

Gerv

Comment 13

[Benoit Jacob [:bjacob] (mostly away)]

Attachment: Add UA override for dailymotion

Comment 14

[Benoit Jacob [:bjacob] (mostly away)]

pull request: https://github.com/mozilla-b2g/gaia/pull/6725

Comment 15

[Alexandre Poirot [:ochameau]]

Landed:
https://github.com/mozilla-b2g/gaia/commit/409c7c0ce1309efcd2d4df38a16e5c62acef8167