Closed
Bug 803741
Opened 12 years ago
Closed 12 years ago
Add UA override for dailymotion.com for B2G
Categories
(Firefox OS Graveyard :: Gaia, defect, P2)
Tracking
(blocking-basecamp:+)
People
(Reporter: tchung, Assigned: bjacob)
References
Details
Attachments
(1 file)
701 bytes,
patch
|
fabrice
:
review+
|
Details | Diff | Splinter Review |
touch.dailymotion.com is mobile optimized for Fennec UA today. lets do the same for the b2g UA: Mozilla/5.0 (Mobile; rv:12.0) Gecko/12.0 Firefox/12.0 Currently on 10-19-2012 build, it shows the desktop site: www.dailymotion.com
Reporter | ||
Updated•12 years ago
|
Summary: Add UA override for yelp.com for B2G → Add UA override for dailymotion.com for B2G
Status: NEW → RESOLVED
Closed: 12 years ago
Resolution: --- → DUPLICATE
Oops, too quick fingers.
Assignee: nobody → lmandel
Status: RESOLVED → REOPENED
Resolution: DUPLICATE → ---
Reporter | ||
Comment 4•12 years ago
|
||
Oh yeah, my justification for blocking+ is that touch.dailymotion.com falls back video content to h.264 on Fennec. We need the same for b2g.
Comment 5•12 years ago
|
||
(In reply to Tony Chung [:tchung] from comment #4) > Oh yeah, my justification for blocking+ is that touch.dailymotion.com falls > back video content to h.264 on Fennec. We need the same for b2g. If we don't fix this, how well does the site operate? Is it a top site in any locales we are tracking?
Comment 6•12 years ago
|
||
This is the same bug as 803742... We want one bug for "contact DailyMotion", and one bug for "add a UA override". We seem to have two of the latter, and none of the former. https://wiki.mozilla.org/Evangelism/UA_Override_List_Policy is how this should work. :-) Gerv
Comment 7•12 years ago
|
||
Bug 803742 is a tech evangelism bug.
Comment 9•12 years ago
|
||
Milestoning for C2 (deadline of 12/10), as this meets the criteria of "known P2 bugs found before or during C1".
Target Milestone: --- → B2G C2 (20nov-10dec)
Updated•12 years ago
|
Assignee: lmandel → bjacob
Assignee | ||
Comment 10•12 years ago
|
||
I have a couple question. My understanding is I should do roughly the same as https://github.com/mozilla-b2g/gaia/pull/6435/files but for dailymotion.com. This patch does: +pref("general.useragent.override.yelp.com", "\(Mobile#(Android; Mobile"); I need to know what the second string here, "\(Mobile#(Android; Mobile", really does (what syntax is that) and how I adapt it to do the UA string overriding asked for in comment 0 --- is the patch as simple as +pref("general.useragent.override.dailymotion.com", "\(Mobile#(Android; Mobile"); ?
Assignee | ||
Comment 11•12 years ago
|
||
Ah, got it: http://mxr.mozilla.org/mozilla-central/source/netwerk/protocol/http/UserAgentOverrides.jsm#74 So this was just about replacing "Mobile" by "Android; Mobile" in the UA string. Is this what you want done here as well for dailymotion?
Comment 12•12 years ago
|
||
Can you also add a comment to that block of prefs explaining the format? :-) Gerv
Assignee | ||
Comment 13•12 years ago
|
||
Attachment #686558 -
Flags: review?(21)
Updated•12 years ago
|
Attachment #686558 -
Flags: review?(21) → review+
Assignee | ||
Comment 14•12 years ago
|
||
pull request: https://github.com/mozilla-b2g/gaia/pull/6725
Comment 15•12 years ago
|
||
Landed: https://github.com/mozilla-b2g/gaia/commit/409c7c0ce1309efcd2d4df38a16e5c62acef8167
Status: REOPENED → RESOLVED
Closed: 12 years ago → 12 years ago
Resolution: --- → FIXED
Updated•12 years ago
|
Component: General → Gaia
You need to log in
before you can comment on or make changes to this bug.
Description
•