Bug 767134 didn't add documentation. Add required documentation. This might also mean more crisply defining what the aRequestPrincipal should be for all the contentpolicy calls.
Attachment #673500 - Flags: review?(bzbarsky)
First attempt. Not sure what the documentation etiquette is, but I am sure the review will point me towards the right path.
Attachment #673500 - Flags: review?(bzbarsky) → review+
Attachment #673500 - Attachment is obsolete: true
Comment on attachment 674542 [details] [diff] [review] Documentation for aRequestPrincipal r=bz Carrying over the r+ from bz. @bz: If you have time to take a look and confirm that the documentation looks right, that would be great. I will wait for a couple of days before requesting check-in.
Attachment #674542 - Flags: review+
Status: NEW → RESOLVED
Last Resolved: 7 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla19
In which cases would the caller be non-gecko code?
Any extension (e.g., noscript, adblock) There might be other cases. bz/dveditz probably know more.
Is there a bug to go through the code and add the Request Principal in gecko code when it's missing?
If I am not wrong, Gecko code should be using NS_CheckContentLoadPolicy anyways, and that should set the requestprincipal properly. Can you point me to examples where it's missing?
You need to log in before you can comment on or make changes to this bug.