803825 - Paris bindings for FileHandle

Status: RESOLVED FIXED

(Core :: DOM: Core & HTML, defect)

Description

[:Ms2ger (he/him; ⌚ UTC+1/+2)]

Attachment: Part a: Introduce NS_IMPL_FORWARD_EVENT_HANDLER_FOR_WEBIDL

Comment 1

[:Ms2ger (he/him; ⌚ UTC+1/+2)]

Attachment: Part b: Paris bindings

Comment 2

[:Ms2ger (he/him; ⌚ UTC+1/+2)]

Ben, ping.

Comment 3

[:Ms2ger (he/him; ⌚ UTC+1/+2)]

Ben, ping.

Comment 4

[:Ms2ger (he/him; ⌚ UTC+1/+2)]

Ben, ping.

Comment 5

[Ben Turner (not reading bugmail, use the needinfo flag!)]

Sorry, I won't have time to look at this until at least the 27th. If you need review sooner you could try khuey.

Comment 6

[Kyle Huey (Exited; not receiving bugmail, old account, do not use)]

Comment on attachment 673554 [details] [diff] [review]
Part b: Paris bindings

Review of attachment 673554 [details] [diff] [review]:
-----------------------------------------------------------------

::: dom/webidl/FileHandle.webidl
@@ +6,5 @@
> +interface LockedFile;
> +
> +enum FileMode { "readonly", "readwrite" };
> +
> +interface FileHandle {

This should inherit from EventTarget.

Comment 7

[:Ms2ger (he/him; ⌚ UTC+1/+2)]

Attachment: Part b: Paris bindings (v2)

Comment 8

[Kyle Huey (Exited; not receiving bugmail, old account, do not use)]

Comment on attachment 680383 [details] [diff] [review]
Part b: Paris bindings (v2)

Review of attachment 680383 [details] [diff] [review]:
-----------------------------------------------------------------

Please file a followup on deCOMtaminating nsIDOMFileHandle.

Comment 9

[:Ms2ger (he/him; ⌚ UTC+1/+2)]

https://hg.mozilla.org/mozilla-central/rev/2a09d5a49ae7
https://hg.mozilla.org/mozilla-central/rev/138665d04a92

Comment 10

[Boris Zbarsky [:bzbarsky]]

Is this used from C++ via the XPCOM APIs?  If not, can we file a followup to drop those?