803861 - [WebAPI] WebTelephony: Tests should wait for 'onalerting' event during outgoing call

Status: RESOLVED FIXED

(Core :: DOM: Device Interfaces, defect)

Description

[Robert Wood [:rwood]]

When making an outgoing call on the B2G emulator using the WebAPI, the test should always wait for the 'onalerting' telephony event before requesting the current call list from the emulator.

Otherwise there is a race condition, and occasionally the emulator will return an empty call list as the call hasn't actually been made yet.  This situation causes the following tests to 'random orange', so they need to be updated:

test_incoming_already_connected.js
test_incoming_already_held.js
test_outgoing_already_held.js
test_outgoing_hold_resume.js

Comment 1

[Robert Wood [:rwood]]

Some more to add to the list:

test_outgoing_answer_hangup.js
test_outgoing_hangup_held.js
test_outgoing_reject.js
test_emergency.js

Comment 2

[Robert Wood [:rwood]]

Attachment: Patch for 803861

Comment 3

[Jonathan Griffin (:jgriffin)]

Comment on attachment 673623 [details] [diff] [review]
Patch for 803861

It would be sweet if this cleared up the intermittent emulator crashes as well!

Comment 4

[Jonathan Griffin (:jgriffin)]

https://hg.mozilla.org/mozilla-central/rev/49e26446d1e0

Comment 5

[Jonathan Griffin (:jgriffin)]

https://hg.mozilla.org/releases/mozilla-aurora/rev/c66bf1ae2d40