803885 - WebRTC unit-test crash [@TransportTestPeer::SendPacket]

Status: RESOLVED FIXED

(Core :: WebRTC: Networking, defect)

Description

[Christoph Diehl [:posidron]]

Attachment: callstack

Run: <obj_dir>/media/mtransport/test/sctp_unittest

This happens to be a bug in the unit test itself, we need to fix this to run the tests accordingly.

alloc:
::TransportTest::ConnectSocket mozalloc.h:200

free:
::TransportTest::~TransportTest sctp_unittest.cpp:291

re-use:
::TransportTestPeer::SendPacket sctp_unittest.cpp:188

This only happens if you run the sctp_unittest as a whole but not when you run each test separately.

Comment 1

[Eric Rescorla (:ekr)]

Christoph, can you provide the whole call stack for the alloc/free/reuse.

Comment 2

[Christoph Diehl [:posidron]]

It's already attached.

Comment 3

[Eric Rescorla (:ekr)]

Attachment: Fix SCTP unit tests

Comment 4

[Randell Jesup [:jesup] (needinfo me)]

Comment on attachment 681032 [details] [diff] [review]
Fix SCTP unit tests

Review of attachment 681032 [details] [diff] [review]:
-----------------------------------------------------------------

r+ with setting r...

::: media/mtransport/test/sctp_unittest.cpp
@@ +85,5 @@
> +    l.l_onoff = 1;
> +    l.l_linger = 0;
> +    usrsctp_setsockopt(sctp_, SOL_SOCKET, SO_LINGER, &l,
> +                       (socklen_t)sizeof(l));
> +    EXPECT_GE(r, 0);

you didn't set r.... though it won't fail!

Comment 5

[Jason Smith [:jsmith]]

Not a candidate for a crashtest, but the unit test will cover the case for automating the crash piece.

Comment 6

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/mozilla-central/rev/5a76abc509c7