803907 - Miscellaneous GC cleanups

Status: RESOLVED FIXED

(Core :: JavaScript Engine, defect)

Comment 1

[Bill McCloskey [inactive unless it's an emergency] (:billm)]

Attachment: remove MapRoots

This appears to be unused.

Comment 2

[Bill McCloskey [inactive unless it's an emergency] (:billm)]

Attachment: remove some debugging code

I have never used this code before. It just seems like a hindrance.

Comment 3

[Bill McCloskey [inactive unless it's an emergency] (:billm)]

Attachment: remove unused functions

These aren't used.

Comment 4

[Bill McCloskey [inactive unless it's an emergency] (:billm)]

Attachment: simplify hashtable iteration

This must have been refactored from one of the old hashtable implementations.

Comment 5

[Terrence Cole [:terrence]]

Comment on attachment 673626 [details] [diff] [review]
remove MapRoots

Review of attachment 673626 [details] [diff] [review]:
-----------------------------------------------------------------

Thanks, I've also been meaning to kill this!

Comment 6

[Terrence Cole [:terrence]]

Comment on attachment 673627 [details] [diff] [review]
remove some debugging code

Review of attachment 673627 [details] [diff] [review]:
-----------------------------------------------------------------

I haven't used this either.

Comment 7

[Terrence Cole [:terrence]]

Comment on attachment 673628 [details] [diff] [review]
remove unused functions

Review of attachment 673628 [details] [diff] [review]:
-----------------------------------------------------------------

Wfm.

Comment 8

[Terrence Cole [:terrence]]

Comment on attachment 673629 [details] [diff] [review]
simplify hashtable iteration

Review of attachment 673629 [details] [diff] [review]:
-----------------------------------------------------------------

Yup.  I've been meaning to do this one too.

Comment 9

[Bill McCloskey [inactive unless it's an emergency] (:billm)]

https://hg.mozilla.org/integration/mozilla-inbound/rev/9679ec5b0b33
https://hg.mozilla.org/integration/mozilla-inbound/rev/fb81587d2dd8
https://hg.mozilla.org/integration/mozilla-inbound/rev/3ff0432ce8d9
https://hg.mozilla.org/integration/mozilla-inbound/rev/2373c969584c

Comment 10

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/mozilla-central/rev/9679ec5b0b33
https://hg.mozilla.org/mozilla-central/rev/fb81587d2dd8
https://hg.mozilla.org/mozilla-central/rev/3ff0432ce8d9
https://hg.mozilla.org/mozilla-central/rev/2373c969584c