Miscellaneous GC cleanups

RESOLVED FIXED in mozilla19

Status

()

Core
JavaScript Engine
RESOLVED FIXED
5 years ago
5 years ago

People

(Reporter: billm, Assigned: billm)

Tracking

unspecified
mozilla19
Points:
---
Bug Flags:
in-testsuite -

Firefox Tracking Flags

(Not tracked)

Details

Attachments

(4 attachments)

Comment hidden (empty)
(Assignee)

Comment 1

5 years ago
Created attachment 673626 [details] [diff] [review]
remove MapRoots

This appears to be unused.
Attachment #673626 - Flags: review?(terrence)
(Assignee)

Comment 2

5 years ago
Created attachment 673627 [details] [diff] [review]
remove some debugging code

I have never used this code before. It just seems like a hindrance.
Attachment #673627 - Flags: review?(terrence)
(Assignee)

Comment 3

5 years ago
Created attachment 673628 [details] [diff] [review]
remove unused functions

These aren't used.
Attachment #673628 - Flags: review?(terrence)
(Assignee)

Comment 4

5 years ago
Created attachment 673629 [details] [diff] [review]
simplify hashtable iteration

This must have been refactored from one of the old hashtable implementations.
Attachment #673629 - Flags: review?(terrence)
Comment on attachment 673626 [details] [diff] [review]
remove MapRoots

Review of attachment 673626 [details] [diff] [review]:
-----------------------------------------------------------------

Thanks, I've also been meaning to kill this!
Attachment #673626 - Flags: review?(terrence) → review+
Comment on attachment 673627 [details] [diff] [review]
remove some debugging code

Review of attachment 673627 [details] [diff] [review]:
-----------------------------------------------------------------

I haven't used this either.
Attachment #673627 - Flags: review?(terrence) → review+
Comment on attachment 673628 [details] [diff] [review]
remove unused functions

Review of attachment 673628 [details] [diff] [review]:
-----------------------------------------------------------------

Wfm.
Attachment #673628 - Flags: review?(terrence) → review+
Comment on attachment 673629 [details] [diff] [review]
simplify hashtable iteration

Review of attachment 673629 [details] [diff] [review]:
-----------------------------------------------------------------

Yup.  I've been meaning to do this one too.
Attachment #673629 - Flags: review?(terrence) → review+
(Assignee)

Comment 9

5 years ago
https://hg.mozilla.org/integration/mozilla-inbound/rev/9679ec5b0b33
https://hg.mozilla.org/integration/mozilla-inbound/rev/fb81587d2dd8
https://hg.mozilla.org/integration/mozilla-inbound/rev/3ff0432ce8d9
https://hg.mozilla.org/integration/mozilla-inbound/rev/2373c969584c
https://hg.mozilla.org/mozilla-central/rev/9679ec5b0b33
https://hg.mozilla.org/mozilla-central/rev/fb81587d2dd8
https://hg.mozilla.org/mozilla-central/rev/3ff0432ce8d9
https://hg.mozilla.org/mozilla-central/rev/2373c969584c
Status: NEW → RESOLVED
Last Resolved: 5 years ago
Flags: in-testsuite-
Resolution: --- → FIXED
Target Milestone: --- → mozilla19
You need to log in before you can comment on or make changes to this bug.