Closed Bug 803977 Opened 8 years ago Closed 8 years ago

Focus ring around buttons in the downloads panel should be rectangular

Categories

(Firefox :: Theme, defect)

defect
Not set
normal

Tracking

()

RESOLVED FIXED
Firefox 19

People

(Reporter: dao, Assigned: dao)

Details

Attachments

(1 file)

Attached patch patchSplinter Review
The outline radius is just unnecessary and rendered badly (changing from dotted to solid).
Attachment #673692 - Flags: review?(mconley)
I think we did this cause the panel top border is rounded, not sure it it looks bad to have the rounded border with a squared focus ring... maybe we could round just the first item, or none if it's not that bad.
The focus ring is approximately 5 pixels away from the panel border and looks just fine being square. The round edges on the other hand do look bad and shouldn't be used even for the first item.
Attachment #673692 - Flags: review?(mak77)
Comment on attachment 673692 [details] [diff] [review]
patch

fine, I trust your theming experience here.
Attachment #673692 - Flags: review?(mconley)
Attachment #673692 - Flags: review?(mak77)
Attachment #673692 - Flags: review+
https://hg.mozilla.org/mozilla-central/rev/08811506ac27
Status: ASSIGNED → RESOLVED
Closed: 8 years ago
Flags: in-testsuite-
Resolution: --- → FIXED
Target Milestone: --- → Firefox 19
You need to log in before you can comment on or make changes to this bug.