Closed
Bug 803977
Opened 12 years ago
Closed 12 years ago
Focus ring around buttons in the downloads panel should be rectangular
Categories
(Firefox :: Theme, defect)
Firefox
Theme
Tracking
()
RESOLVED
FIXED
Firefox 19
People
(Reporter: dao, Assigned: dao)
Details
Attachments
(1 file)
|
2.04 KB,
patch
|
mak
:
review+
|
Details | Diff | Splinter Review |
The outline radius is just unnecessary and rendered badly (changing from dotted to solid).
Attachment #673692 -
Flags: review?(mconley)
|
||
Comment 1•12 years ago
|
||
I think we did this cause the panel top border is rounded, not sure it it looks bad to have the rounded border with a squared focus ring... maybe we could round just the first item, or none if it's not that bad.
|
Assignee | |
Comment 2•12 years ago
|
||
The focus ring is approximately 5 pixels away from the panel border and looks just fine being square. The round edges on the other hand do look bad and shouldn't be used even for the first item.
|
|
Assignee | |
Updated•12 years ago
|
Attachment #673692 -
Flags: review?(mak77)
|
|
||
Comment 3•12 years ago
|
||
Comment on attachment 673692 [details] [diff] [review] patch fine, I trust your theming experience here.
Attachment #673692 -
Flags: review?(mconley)
Attachment #673692 -
Flags: review?(mak77)
Attachment #673692 -
Flags: review+
|
|
Assignee | |
Comment 4•12 years ago
|
||
https://hg.mozilla.org/integration/mozilla-inbound/rev/08811506ac27
|
||
Comment 5•12 years ago
|
||
https://hg.mozilla.org/mozilla-central/rev/08811506ac27
Status: ASSIGNED → RESOLVED
Closed: 12 years ago
Flags: in-testsuite-
Resolution: --- → FIXED
Target Milestone: --- → Firefox 19
You need to log in
before you can comment on or make changes to this bug.
Description
•