804226 - [OTA update] Nightly updater is throwing [Exception... "Could not convert JavaScript argument arg 0 [nsIUpdateCheckListener.onProgress]"

Status: VERIFIED FIXED

Description

[Tony Chung [:tchung]]

When updating on nightly unagi from 10-21-2012 build, an updater error is thrown:
E/GeckoConsole(876): [JavaScript Error: "[Exception... "Could not convert JavaScript argument arg 0 [nsIUpdateCheckListener.onProgress]"  nsresult: "0x80570009 (NS_ERROR_XPC_BAD_CONVERT_JS)"  location: "JS frame :: jar:file:///system/b2g/omni.ja!/components/nsUpdateService.js :: Downloader_onProgress :: line 2910"  data: no]" {file: "jar:file:///system/b2g/omni.ja!/components/nsUpdateService.js" line: 2910}]

Update fails to proceed.

Logcat:
10-22 10:24:03.029: I/Gecko(876): *** AUS:SVC Downloader:onProgress - progress: 14543511/44521886
10-22 10:24:03.029: E/GeckoConsole(876): AUS:SVC Downloader:onProgress - progress: 14543511/44521886
10-22 10:24:03.029: E/GeckoConsole(876): [JavaScript Error: "[Exception... "Could not convert JavaScript argument arg 0 [nsIUpdateCheckListener.onProgress]"  nsresult: "0x80570009 (NS_ERROR_XPC_BAD_CONVERT_JS)"  location: "JS frame :: jar:file:///system/b2g/omni.ja!/components/nsUpdateService.js :: Downloader_onProgress :: line 2910"  data: no]" {file: "jar:file:///system/b2g/omni.ja!/components/nsUpdateService.js" line: 2910}]
10-22 10:24:04.019: I/Gecko(876): *** AUS:SVC Downloader:onProgress - progress: 14739993/44521886
10-22 10:24:04.019: E/GeckoConsole(876): AUS:SVC Downloader:onProgress - progress: 14739993/44521886
10-22 10:24:04.019: E/GeckoConsole(876): [JavaScript Error: "[Exception... "Could not convert JavaScript argument arg 0 [nsIUpdateCheckListener.onProgress]"  nsresult: "0x80570009 (NS_ERROR_XPC_BAD_CONVERT_JS)"  location: "JS frame :: jar:file:///system/b2g/omni.ja!/components/nsUpdateService.js :: Downloader_onProgress :: line 2910"  data: no]" {file: "jar:file:///system/b2g/omni.ja!/components/nsUpdateService.js" line: 2910}]
10-22 10:24:05.309: I/Gecko(876): *** AUS:SVC Downloader:onProgress - progress: 14741367/44521886
10-22 10:24:05.309: E/GeckoConsole(876): AUS:SVC Downloader:onProgress - progress: 14741367/44521886
10-22 10:24:05.309: E/GeckoConsole(876): [JavaScript Error: "[Exception... "Could not convert JavaScript argument arg 0 [nsIUpdateCheckListener.onProgress]"  nsresult: "0x80570009 (NS_ERROR_XPC_BAD_CONVERT_JS)"  location: "JS frame :: jar:file:///system/b2g/omni.ja!/components/nsUpdateService.js :: Downloader_onProgress :: line 2910"  data: no]" {file: "jar:file:///system/b2g/omni.ja!/components/nsUpdateService.js" line: 2910}]
10-22 10:24:05.829: I/Gecko(876): *** AUS:SVC Downloader:onProgress - progress: 14756481/44521886
10-22 10:24:05.829: E/GeckoConsole(876): AUS:SVC Downloader:onProgress - progress: 14756481/44521886
10-22 10:24:05.829: E/GeckoConsole(876): [JavaScript Error: "[Exception... "Could not convert JavaScript argument arg 0 [nsIUpdateCheckListener.onProgress]"  nsresult: "0x80570009 (NS_ERROR_XPC_BAD_CONVERT_JS)"  location: "JS frame :: jar:file:///system/b2g/omni.ja!/components/nsUpdateService.js :: Downloader_onProgress :: line 2910"  data: no]" {file: "jar:file:///system/b2g/omni.ja!/components/nsUpdateService.js" line: 2910}]
10-22 10:24:06.109: I/ONCRPC(116): rpc_handle_rpc_call: for Xid: 369, Prog: 31000000, Vers: fc37ad5c, Proc: 00000012
10-22 10:24:06.109: I/ONCRPC(116): rpc_handle_rpc_call: Find Status: 0 Xid: 369
10-22 10:24:06.109: I/ONCRPC(116): oncrpc_proxy_handle_cmd_rpc_call: Dispatching xid: 369
10-22 10:24:06.359: I/Gecko(876): *** AUS:SVC Downloader:onProgress - progress: 14775717/44521886
10-22 10:24:06.359: E/GeckoConsole(876): AUS:SVC Downloader:onProgress - progress: 14775717/44521886
10-22 10:24:06.359: E/GeckoConsole(876): [JavaScript Error: "[Exception... "Could not convert JavaScript argument arg 0 [nsIUpdateCheckListener.onProgress]"  nsresult: "0x80570009 (NS_ERROR_XPC_BAD_CONVERT_JS)"  location: "JS frame :: jar:file:///system/b2g/omni.ja!/components/nsUpdateService.js :: Downloader_onProgress :: line 2910"  data: no]" {file: "jar:file:///system/b2g/omni.ja!/components/nsUpdateService.js" line: 2910}]
10-22 10:24:09.579: I/Gecko(876): *** AUS:SVC Downloader:onProgress - progress: 14781213/44521886
10-22 10:24:09.579: E/GeckoConsole(876): AUS:SVC Downloader:onProgress - progress: 14781213/44521886
10-22 10:24:09.579: E/GeckoConsole(876): [JavaScript Error: "[Exception... "Could not convert JavaScript argument arg 0 [nsIUpdateCheckListener.onProgress]"  nsresult: "0x80570009 (NS_ERROR_XPC_BAD_CONVERT_JS)"  location: "JS frame :: jar:file:///system/b2g/omni.ja!/components/nsUpdateService.js :: Downloader_onProgress :: line 2910"  data: no]" {file: "jar:file:///system/b2g/omni.ja!/components/nsUpdateService.js" line: 2910}]
10-22 10:24:18.549: E/GeckoConsole(876): CC(T+193.6) duration: 29ms, suspected: 78, visited: 1723 RCed and 1429 GCed, collected: 0 RCed and 0 GCed (43 waiting for GC)
10-22 10:24:18.549: E/GeckoConsole(876): ForgetSkippable 24 times before CC, min: 1 ms, max: 67 ms, avg: 9 ms, total: 229 ms, removed: 2827
10-22 10:24:18.639: I/IdleService(876): next timeout 1350926659651731 usec (999 msec from now)
10-22 10:24:18.639: I/IdleService(876): SetTimerExpiryIfBefore: next timeout 1350926659651731 usec
10-22 10:24:18.639: I/IdleService(876): reset timer expiry from 1350926940351873 usec to 1350926659661731 usec
10-22 10:24:18.639: I/IdleService(876): Reset idle timeout: tell observer 489c7640 user is back

Repro:
1) install 10-21-2012 unagi nightly build
Gecko: ca1f327d5acc198bb4be62fa51db2c039032c9ce
Gaia: 6a02c47d779ee137c889e5de97fce7ca9a3a31dc
2) search for updates to a newer build on the nightly channel
3) Verify GeckoConsole errors during downloading

Expected:
- no errors, download is successful for updates

Actual:
- gecko errors, halts updating

Comment 1

[Marshall Culpepper [:marshall_law]]

Created attachment 673955 [details] [diff] [review]
b2g update check listener - v1

Overriding nsIUpdateCheckListener caused us to have two functions named onProgress :(

Comment 2

[[:fabrice] Fabrice Desré]

Comment on attachment 673955 [details] [diff] [review]
b2g update check listener - v1

Review of attachment 673955 [details] [diff] [review]:
-----------------------------------------------------------------

::: b2g/components/UpdatePrompt.js
@@ +48,5 @@
> +  this._updatePrompt = updatePrompt;
> +}
> +
> +UpdateCheckListener.prototype = {
> +  classID: Components.ID("{9f1ebd52-6855-46cf-b4b5-fe4a5616eddb}"),

You don't need a classID.

Comment 3

[Marshall Culpepper [:marshall_law]]

https://hg.mozilla.org/integration/mozilla-inbound/rev/131f5d10c49d

Comment 4

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/mozilla-central/rev/131f5d10c49d

Comment 5

[Marshall Culpepper [:marshall_law]]

https://hg.mozilla.org/releases/mozilla-aurora/rev/cc90d089743c

Comment 6

[Tony Chung [:tchung]]

Verified fix when updating 10/25->10/26 nightly.   exceptions are gone.