804311 - imgur.com "original" (non-mobile) uploader triggers "Well, this is embarrassing. We tried to display this webpage, but it's not responding."

Status: RESOLVED FIXED

(Firefox OS Graveyard :: General, defect)

Description

[Daniel Holbert [:dholbert]]

STR:
 1. Visit http://imgur.com/?original in the B2G browser.
 2. Once the "Computer | Web" buttons are visible (under "Upload images"), hit the "Computer" button

ACTUAL RESULTS:
 Page immediately changes to a gray special-page saying:
> Well, this is embarrassing.
>
>  [sad icon]
>
> We tried to display this webpage, but
> it's not responding.

Comment 1

[Daniel Holbert [:dholbert]]

That "embarrassing" page also has buttons at the bottom:
 [Close Tab]  [Reload]

Reload seems to work, but Close Tab does not. (it has no effect, if that's the only tab.  Or -- if you have additional tabs open, it blanks the screen but does not close the tab.)

Comment 2

[Daniel Holbert [:dholbert]]

Attachment: screenshot

Comment 3

[Ben Francis [:benfrancis]]

Thanks for reporting this. There are a few issues here:

1. The "Close Tab" button doesn't work. This button shouldn't be displayed if there is only one tab open, this should be fixed in a more recent build under bug 797272
2. The browser displays a crash screen. The browser app is correctly responding to a fatal error event received because the content process of the tab has crashed.
3. The content process crashes. It looks like this is caused by trying to pick a file using an input type="file" element. This is an unsupported feature in v1 but I think that it causing a process crash may be a regression.

Moving this to the general Boot2Gecko component so that the cause of the crash can be investigated further.

Comment 4

[Jonas Sicking (:sicking) No longer reading bugmail consistently]

Bug 801635 is about implementing a filepicker. So that will ensure that we're not crashing.

Marking as dependent so that we check that this doesn't crash once that bug is fixed.

Comment 5

[Ben Francis [:benfrancis]]

This bug is set as blocking-basecamp+, but is blocked by bug 801635 which is marked as blocking-basecamp-

Support for file uploads was dropped as a v1 requirement a month ago in bug 796384

Although it would be great not to have this limitation, we are past feature freeze and this seems like feature work which hasn't had driver approval.

Would a bug fix which prevents this from crashing the content process be enough?

Comment 6

[Jonas Sicking (:sicking) No longer reading bugmail consistently]

Yup, a patch which fixes the crash would definitely be enough to fix this bug.

Comment 7

[Andrea Marchesini [:baku]]

Attachment: patch

This patch removes the nsFilePicker from the manifest.
This seems enough to fix the bug.

Comment 8

[Andrea Marchesini [:baku]]

Attachment: patch

Comment 9

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/integration/mozilla-inbound/rev/e57d9d6a66ae

Comment 10

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/mozilla-central/rev/e57d9d6a66ae

Comment 11

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/releases/mozilla-aurora/rev/34c4f8b76f49