804404 - (xpcshell?) myFunction.toString() (as in Function.toString) returns "[sourceless code]" as the function body when loading scripts via Cu.utils.import/subscriptloader

Status: RESOLVED FIXED

(Core :: JavaScript Engine, defect)

Description

[James Lal [:lightsofapollo]]

Attachment: minimal test case (spans multiple files, README.md within)

This is a regression from sometime between Aug 7th mozilla central xpcshell and now. The rational behind the use of Function.toString is to send javascript function bodies over marionette for gaia integration tests. Web content appears to work as expected.

Comment 1

[:Benjamin Peterson]

Attachment: set source hook in xpc

This simply moves the source hook code to XPConnect (no behavior change), so it gets used by xpcshell.

Comment 2

[Boris Zbarsky [:bzbarsky]]

Comment on attachment 674294 [details] [diff] [review]
set source hook in xpc

r=me

Comment 3

[:Benjamin Peterson]

https://hg.mozilla.org/integration/mozilla-inbound/rev/986b4cb7678e

Comment 4

[:Benjamin Peterson]

Comment on attachment 674294 [details] [diff] [review]
set source hook in xpc

[Approval Request Comment]
Low risk patch, which just moves code around. Wanted for b2g.

Comment 5

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/mozilla-central/rev/986b4cb7678e

Should this have a test?

Comment 6

[bhavana bajaj [:bajaj]]

Comment on attachment 674294 [details] [diff] [review]
set source hook in xpc

Approving as it is a low risk patch , needed for b2g

Comment 7

[:Benjamin Peterson]

https://hg.mozilla.org/releases/mozilla-aurora/rev/b6f00660c974