Closed Bug 804432 Opened 12 years ago Closed 12 years ago

[socorro-crashstats] page title for crash trends is wrong

Categories

(Socorro :: Webapp, task)

task
Not set
normal

Tracking

(Not tracked)

VERIFIED FIXED

People

(Reporter: stephend, Assigned: espressive)

References

()

Details

The page title on http://crash-stats-new-dev.allizom.org/crash_trends/products/Firefox is "Mozilla Products in Crash Reporter", but it should be:

"Crash Trends Report For Firefox 19.0a1" (or latest version)
Actually a slightly bigger bug than that.  In prod, the default behavior for crash_trends is to by default display data for latest nightly (and have that in the title).  

In dev the data you get by default is different...not sure where it's coming from, but I'll check that next.
(In reply to Laura Thomson :laura from comment #1)
> Actually a slightly bigger bug than that.  In prod, the default behavior for
> crash_trends is to by default display data for latest nightly (and have that
> in the title).  
> 
> In dev the data you get by default is different...not sure where it's coming
> from, but I'll check that next.

I think Schalk worked on this - these two pages look different even though they are using the same middleware (and so shouldn't):

http://crash-stats-new-dev.allizom.org/crash_trends/products/Firefox
https://crash-stats-dev.allizom.org/crash_trends
Assignee: nobody → sneethling
Working on this one, have resolved the one problem. Looking at the other one now.
You can see here that the data I get back from the middleware is completely different in the two environments:

http://hastebin.com/xurapogisa.cpp
Forgot to mention, that the params sent are exactly the same:

== crash-stats-new-dev ==

end_date	2012-10-24
product	Firefox
start_date	2012-10-17
version	19.0a1

== crash-stats-dev ==

end_date	2012-10-24
product	Firefox
start_date	2012-10-17
version	19.0a1
Ignore my last comments, spoke to Laura on IRC and I misunderstood the secondary bug, all is fixed in: https://github.com/mozilla/socorro-crashstats/pull/217
Commits pushed to master at https://github.com/mozilla/socorro-crashstats

https://github.com/mozilla/socorro-crashstats/commit/a8e227f7adeb6a7e04e24861e4e0bfc6ecd3060b
fixes title and initial date range which fixes bug 804432

https://github.com/mozilla/socorro-crashstats/commit/684fbdda010b459cbe3aebfe1f478cd7f4034e49
Merge pull request #217 from ossreleasefeed/crash-trends-title-wrong-804432

fixes title and initial date range which fixes bug 804432
Status: NEW → RESOLVED
Closed: 12 years ago
Resolution: --- → FIXED
(In reply to Laura Thomson :laura from comment #1)
> Actually a slightly bigger bug than that.  In prod, the default behavior for
> crash_trends is to by default display data for latest nightly (and have that
> in the title).  
> 
> In dev the data you get by default is different...not sure where it's coming
> from, but I'll check that next.

Actually, https://crash-stats.mozilla.com/crash_trends displays "Crash Trends Report For Firefox 19.0a1" as its title, but I'm not trying to quibble.

The changes to fix the title to now be "Nightly Crash Trends For Firefox 19.0a1" make sense to me, just want to be sure that's intended.
[:stephend] It is intended. This now matches the on page heading.
Thx, verified.
Status: RESOLVED → VERIFIED
You need to log in before you can comment on or make changes to this bug.