804526 - Presentation mode does not work in pdf.js

Status: VERIFIED FIXED

(Firefox :: PDF Viewer, defect, P3)

Description

[Philipp Wagner [:imphil]]

STR:
1) Go to http://www.freepatentsonline.com/EP2012324.pdf
2) Above the PDF, click on the "Presentation mode" icon (left of the printer icon)

Expected result:
The PDF opens in fullscreen

Actual result:
The next PDF page is shown, no fullscreen window opens.

The error console gives the following message:
============
Timestamp: 23.10.2012 11:43:36
Warning: Request for full-screen was denied because at least one of the document's containing iframes does not have a "mozallowfullscreen" attribute.
Source File: http://pdf.sumobrain.com/EP2012324B1.pdf?AWSAccessKeyId=AKIAIBOKHYOLP4MBMRGQ&Expires=1351124828&Signature=MtAIxGd2prkqBEPqyjSrJvFnzDo%3D
Line: 0
============


Nightly 19.0a1 (2012-10-22)

Comment 1

[david.smitmanis]

It actually sort of enters Presentation mode; it switches to one page at a time and the presentation mode controls are active rather than the regular ones. As you say, it doesn't enter fullscreen though, and the toolbar remains.

Comment 2

[Brendan Dahl [:bdahl]]

This happens when pdf.js is an iframe.  We'll need to either disable the button or figure out how to make it work correctly.

Comment 3

[Philipp Wagner [:imphil]]

Actually, when clicking that button I didn't expect the "presentation mode" to turn up, but to get a larger view of the PDF (like in a new window or something), to make it easier to read, since it's quite small in that iframe. I'm not saying that the presentation mode should be changed or anything, just to show you what my actual expectation was when clicking on that button.

So maybe disable presentation mode, but (sometime later and in another bug) introduce a "open in separate window" button?

Comment 4

[Yury Delendik (:yury)]

probably it's not trivial but last button in the toolbar (current view) will do that

Comment 5

[Jakob Miland]

Quite trivial fix:
https://github.com/mozilla/pdf.js/pull/2363

Comment 6

[Ryan VanderMeulen [:RyanVM]]

Fixed by bug 810107.

Comment 7

[Mihaela Velimiroviciu (:mihaelav)]

Mozilla/5.0 (X11; Linux i686; rv:20.0) Gecko/20121217 Firefox/20.0
Mozilla/5.0 (X11; Linux i686; rv:19.0) Gecko/20121217 Firefox/19.0

Verified the fix on latest Nightly and Aurora builds: PDFs enter full screen mode correctly.