804536 - Build broken: "Error populating virtualenv"

Status: RESOLVED FIXED

(Firefox Build System :: General, defect)

Description

[Robert O'Callahan (:roc) (email my personal email if necessary)]

Changset c6fe2305d29c. Clean build in a new directory using
  pymake -sC obj-ff-debug2 -f ../client.mk
MOZCONFIG in use, but probably not relevant since it always worked before and has nothing fancy in it.

Build fails like so:

Installing pip...................done.
Traceback (most recent call last):
  File "z:/roc/mozilla-inbound/build/virtualenv/populate_virtualenv.py", line 319, in <module>
    manager.populate()
  File "z:/roc/mozilla-inbound/build/virtualenv/populate_virtualenv.py", line 140, in populate
    fh = open(self.manifest_path, 'rUt')
ValueError: Invalid mode ('rbt')
Traceback (most recent call last):
  File "z:/roc/mozilla-inbound/build/virtualenv/populate_virtualenv.py", line 321, in <module>
    manager.ensure()
  File "z:/roc/mozilla-inbound/build/virtualenv/populate_virtualenv.py", line 75, in ensure
    return self.build()
  File "z:/roc/mozilla-inbound/build/virtualenv/populate_virtualenv.py", line 270, in build
    raise Exception('Error populating virtualenv.')
Exception: Error populating virtualenv.

Comment 1

[Robert O'Callahan (:roc) (email my personal email if necessary)]

Python 2.7.2 from MozillaBuild, if that helps.

Comment 2

[Honza Bambas (:mayhemer)]

Same problem for me.  Python 2.7.2 from MozillaBuild as well.


checking for python2.7... /c/Mozilla/mozilla-build/python/python2.7
Creating Python environment
New python executable in c:/Mozilla/src/mozilla-central/_obj-browser-debug/_virtualenv\Scripts\python2.7.exe
Also creating executable in c:/Mozilla/src/mozilla-central/_obj-browser-debug/_virtualenv\Scripts\python.exe
Installing setuptools................done.
Installing pip...................done.
Traceback (most recent call last):
  File "c:/Mozilla/src/mozilla-central/build/virtualenv/populate_virtualenv.py", line 319, in <module>
    manager.populate()
  File "c:/Mozilla/src/mozilla-central/build/virtualenv/populate_virtualenv.py", line 140, in populate
    fh = open(self.manifest_path, 'rUt')
ValueError: Invalid mode ('rbt')
Traceback (most recent call last):
  File "c:/Mozilla/src/mozilla-central/build/virtualenv/populate_virtualenv.py", line 321, in <module>
    manager.ensure()
  File "c:/Mozilla/src/mozilla-central/build/virtualenv/populate_virtualenv.py", line 75, in ensure
    return self.build()
  File "c:/Mozilla/src/mozilla-central/build/virtualenv/populate_virtualenv.py", line 270, in build
    raise Exception('Error populating virtualenv.')
Exception: Error populating virtualenv.
*** Fix above errors and then restart with               "c:/Mozilla/mozilla-build/python/python.exe c:/Mozilla/src/mozilla-central/build/pymake/pymake/../mak
e.py -f client.mk build"
c:\Mozilla\src\mozilla-central\client.mk:310:0: command 'cd c:/Mozilla/src/mozilla-central/_obj-browser-debug &&  MAKE="c:/Mozilla/mozilla-build/python/python
.exe c:/Mozilla/src/mozilla-central/build/pymake/pymake/../make.py"  c:/Mozilla/src/mozilla-central/configure  \
  || ( echo "*** Fix above errors and then restart with\
               \"c:/Mozilla/mozilla-build/python/python.exe c:/Mozilla/src/mozilla-central/build/pymake/pymake/../make.py -f client.mk build\"" && exit 1 )' f
ailed, return code 1
c:\Mozilla\src\mozilla-central\client.mk:322:0: command 'c:/Mozilla/mozilla-build/python/python.exe c:/Mozilla/src/mozilla-central/build/pymake/pymake/../make
.py -f c:/Mozilla/src/mozilla-central/client.mk configure' failed, return code 2
c:\Mozilla\src\mozilla-central\client.mk:152:0: command 'c:/Mozilla/mozilla-build/python/python.exe c:/Mozilla/src/mozilla-central/build/pymake/pymake/../make
.py -f c:/Mozilla/src/mozilla-central/client.mk realbuild' failed, return code 2

Comment 3

[Gregory Szorc [:gps]]

Attachment: Hopefuly fix, v1

I haven't tested but I'm reasonably confident this fixes it.

I'll land straight in m-c.

Comment 4

[Mike Hommey [:glandium]]

Comment on attachment 674247 [details] [diff] [review]
Hopefuly fix, v1

Review of attachment 674247 [details] [diff] [review]:
-----------------------------------------------------------------

I made roc try that earlier, so i know it works.

Comment 5

[Gregory Szorc [:gps]]

https://hg.mozilla.org/mozilla-central/rev/a517f7ea5bef

I wonder why buildbot didn't catch this...

Comment 6

[(not currently active) Ted Mielczarek]

The build slaves aren't running a stock MozillaBuild, FWIW. I'm not sure of the exact versions of things they have.

Comment 7

[Chris Cooper [:coop] (he/him)]

Can this fix land on comm-central too, please? Nightly repacks for Thunderbird on Windows are currently broken.

Comment 8

[Justin Wood (:Callek)]

(In reply to Chris Cooper [:coop] from comment #7)
> Can this fix land on comm-central too, please? Nightly repacks for
> Thunderbird on Windows are currently broken.

There is no comm-* copy of that file, however I know mcsmurf is working on a py+virtualenv syncup for configure for us in Bug 803834 which is currently being staged on comm-try for TB

Comment 9

[Chris Cooper [:coop] (he/him)]

Since bug 803834 is FIXED now, we just need a corresponding config change for Thunderbird in the buildbot-configs.