804614 - crash in nsDiskCacheStreamIO::Write

Status: VERIFIED FIXED

(Core :: Networking: Cache, defect)

Description

[Scoobidiver (away)]

It's #20 top browser crasher in 18.0a2 and #70 in 19.0a1.
It first appeared in 18.0a1/20120907. The regression range is:
http://hg.mozilla.org/mozilla-central/pushloghtml?fromchange=0c4fa25f637b&tochange=36427d4b2cf6
It's likely a regression from bug 405407.

Signature 	memcpy | nsDiskCacheStreamIO::Write(char const*, unsigned int, unsigned int*) More Reports Search
UUID	a75038a1-bb2f-45d4-a7df-9e2992121023
Date Processed	2012-10-23 13:09:12
Uptime	1731
Last Crash	6.5 weeks before submission
Install Age	28.9 minutes since version was first installed.
Install Time	2012-10-23 12:39:24
Product	Firefox
Version	19.0a1
Build ID	20121019030551
Release Channel	nightly
OS	Windows NT
OS Version	6.1.7601 Service Pack 1
Build Architecture	x86
Build Architecture Info	GenuineIntel family 6 model 42 stepping 7
Crash Reason	EXCEPTION_ACCESS_VIOLATION_WRITE
Crash Address	0x3f0a
App Notes 	
AdapterVendorID: 0x8086, AdapterDeviceID: 0x0102, AdapterSubsysID: 76801462, AdapterDriverVersion: 8.15.10.2509
D2D? D2D+ DWrite? DWrite+ D3D10 Layers? D3D10 Layers+ 
EMCheckCompatibility	True
Adapter Vendor ID	0x8086
Adapter Device ID	0x0102
Total Virtual Memory	4294836224
Available Virtual Memory	3642687488
System Memory Use Percentage	89
Available Page File	1915817984
Available Physical Memory	211574784

Frame 	Module 	Signature 	Source
0 	msvcr100.dll 	memcpy 	f:\dd\vctools\crt_bld\SELF_X86\crt\src\INTEL\memcpy.asm:256
1 	xul.dll 	nsDiskCacheStreamIO::Write 	netwerk/cache/nsDiskCacheStreams.cpp:565
2 	xul.dll 	nsCacheEntryDescriptor::nsOutputStreamWrapper::Write 	netwerk/cache/nsCacheEntryDescriptor.cpp:906
3 	xul.dll 	nsInputStreamTeeWriteEvent::Run 	xpcom/io/nsInputStreamTee.cpp:98
4 	xul.dll 	nsThread::ProcessNextEvent 	xpcom/threads/nsThread.cpp:612
5 	xul.dll 	nsThread::ThreadFunc 	xpcom/threads/nsThread.cpp:256
6 	nspr4.dll 	_PR_NativeRunThread 	nsprpub/pr/src/threads/combined/pruthr.c:395
7 	nspr4.dll 	pr_root 	nsprpub/pr/src/md/windows/w95thred.c:90
8 	msvcr100.dll 	_callthreadstartex 	f:\dd\vctools\crt_bld\self_x86\crt\src\threadex.c:314
9 	msvcr100.dll 	_threadstartex 	f:\dd\vctools\crt_bld\self_x86\crt\src\threadex.c:292
10 	kernel32.dll 	BaseThreadInitThunk 	
11 	ntdll.dll 	__RtlUserThreadStart 	
12 	ntdll.dll 	_RtlUserThreadStart

More reports at:
https://crash-stats.mozilla.com/report/list?signature=memcpy+|+nsDiskCacheStreamIO%3A%3AWrite%28char+const*%2C+unsigned+int%2C+unsigned+int*%29
https://crash-stats.mozilla.com/report/list?signature=_VEC_memcpy+|+nsDiskCacheStreamIO%3A%3AWrite%28char+const*%2C+unsigned+int%2C+unsigned+int*%29

Comment 1

[Alfred Kayser]

Bug 814010 is to solve the buffer crash issues bu safeguarding the buffer better and only using it for the first 16K of data.

Comment 2

[Josh Aas]

This should be resolved with the backout of 405407.

Comment 3

[Virgil Dicu [:virgil] [QA]]

(In reply to Scoobidiver from comment #0)
> More reports at:
> https://crash-stats.mozilla.com/report/
> list?signature=memcpy+|+nsDiskCacheStreamIO%3A%3AWrite%28char+const*%2C+unsig
> ned+int%2C+unsigned+int*%29
> https://crash-stats.mozilla.com/report/
> list?signature=_VEC_memcpy+|+nsDiskCacheStreamIO%3A%3AWrite%28char+const*%2C+
> unsigned+int%2C+unsigned+int*%29

No crashes after 28th of november (after backout). Setting this to verified.