804633 - [socorro-crashstats] Double-encode special chars in middleware URLs

Status: VERIFIED FIXED

(Socorro :: Webapp, task)

Description

[[DEACTIVATED] Adrian Gaudebert]

We need to double-encode slashes and pluses in signatures in middleware URLs before calling them.

Comment 1

[[DEACTIVATED] Adrian Gaudebert]

PR: https://github.com/mozilla/socorro-crashstats/pull/216

Comment 2

[[DEACTIVATED] Adrian Gaudebert]

Test case for this is for example: http://crash-stats-new-dev.allizom.org/query/?query=..%2f..%2f..%2f..%2f..%2f..%2f..%2f..%2f..%2f..%2fboot.ini&query_type=simple

Or run any search containing a + or a / in the signature field.

Comment 3

[[github robot]]

Commits pushed to master at https://github.com/mozilla/socorro-crashstats

https://github.com/mozilla/socorro-crashstats/commit/6285cdf1ed74f1aa986003a770fc5e6334bf6f90
Fixes bug 804633 - Double-encode slashes and pluses in signature parameters in middleware URLs.

https://github.com/mozilla/socorro-crashstats/commit/be776ecb16e100ae7ddb744170378e79987a5ae0
Merge pull request #216 from AdrianGaudebert/804633-double-encode-signatures

Fixes bug 804633 - Double-encode slashes and pluses in signature paramet...

Comment 4

[Stephen Donner [:stephend] Not actively reading bugmail]

Verified FIXED:

[11:38:36.699] GET http://crash-stats-new-dev.allizom.org/query/?query=..%2f..%2f..%2f..%2f..%2f..%2f..%2f..%2f..%2f..%2fboot.ini&query_type=simple [HTTP/1.1 200 OK 2309ms]