Closed Bug 804680 Opened 9 years ago Closed 9 years ago

B2G STK: support MORE TIME

Categories

(Core :: DOM: Device Interfaces, defect)

ARM
Gonk (Firefox OS)
defect
Not set
normal

Tracking

()

RESOLVED FIXED
mozilla20
blocking-b2g shira+
Tracking Status
firefox19 --- wontfix
firefox20 --- fixed
b2g18 --- fixed
b2g18-v1.0.0 --- wontfix
b2g18-v1.0.1 --- fixed

People

(Reporter: philikon, Assigned: edgar)

References

Details

(Whiteboard: [mno11])

Attachments

(4 files, 11 obsolete files)

3.64 KB, patch
Details | Diff | Splinter Review
1.59 KB, patch
Details | Diff | Splinter Review
2.62 KB, patch
Details | Diff | Splinter Review
1.89 KB, patch
Details | Diff | Splinter Review
No description provided.
MORE Time is sesssion 6.4.4 in TS 101.267 / TS 11.14
Assignee: nobody → echen
Attached patch Part1: IDL for MORE_TIME, v1 (obsolete) — Splinter Review
1). correct typo "cndDetailed"
2). remove trailing space
Attachment #682986 - Attachment is obsolete: true
Attached patch Part1: IDL for MORE_TIME, v2 (obsolete) — Splinter Review
1). rebase
Attachment #682985 - Attachment is obsolete: true
1). rebase
2). mark as MORE_TIME supported.
Attachment #682999 - Attachment is obsolete: true
1). rebase
2). use STK_CMD_MORE_TIME instead of 0x02
Attachment #682991 - Attachment is obsolete: true
Comment on attachment 683039 [details] [diff] [review]
Part1: IDL for MORE_TIME, v2

Review of attachment 683039 [details] [diff] [review]:
-----------------------------------------------------------------

"The ME shall take no extraordinary action when it receives this command, and all other operations shall be unaffected." Then why should we expose an event to content that nothing has to be done?
Attachment #683039 - Flags: review-
(In reply to Vicamo Yang [:vicamo][:vyang] from comment #9)
> Comment on attachment 683039 [details] [diff] [review]
> Part1: IDL for MORE_TIME, v2
> 
> Review of attachment 683039 [details] [diff] [review]:
> -----------------------------------------------------------------
> 
> "The ME shall take no extraordinary action when it receives this command,
> and all other operations shall be unaffected." Then why should we expose an
> event to content that nothing has to be done?

I think we may need to let application know currently SIM status is busy and need more time to process.
Hi, Michael

ETSI TS 102 223 V11.0.0, 
6.4.4  MORE TIME, 
"This procedure is provided to allow the CAT task in the UICC more time for processing, where the processing is so long that it is in danger of affecting normal operation, and clock stop prevents processing to take place in the background."

In Android STK document, this proactive command is marked as "Implement by Baseband".
http://www.kandroid.org/online-pdk/guide/stk.html

Dose it mean this command will be handled by modem?
Do you have any information about this? :)

Thanks
(In reply to Edgar Chen [:edgar] from comment #11)
> Dose it mean this command will be handled by modem?
> Do you have any information about this? :)

Like what we have in PROFILE_DOWNLOAD, even modem firmware has already covered it and doesn't propagate that even up to Gecko, we'll still have to provide our own implementation.
1). remove IDL
2). send TERMINAL_RESPONSE (OK) in ril_worker
Attachment #683039 - Attachment is obsolete: true
Attachment #683045 - Attachment is obsolete: true
Attachment #683060 - Attachment is obsolete: true
1). just rename title.
Attachment #684254 - Attachment is obsolete: true
Attachment #685955 - Flags: review?(allstars.chh)
Attachment #684255 - Attachment is obsolete: true
Attachment #685959 - Flags: review?(allstars.chh)
Comment on attachment 685955 [details] [diff] [review]
Part1: Support MORE_TIME in RIL, v4

Review of attachment 685955 [details] [diff] [review]:
-----------------------------------------------------------------

Great,
remember to add r=me in your patch.
Attachment #685955 - Flags: review?(allstars.chh) → review+
Attachment #685959 - Flags: review?(allstars.chh) → review+
1). rebase
2). add reviewer's name in patch after review+
Attachment #685955 - Attachment is obsolete: true
1). rebase
2). add reviewer's name in patch after review+
Attachment #685959 - Attachment is obsolete: true
https://hg.mozilla.org/mozilla-central/rev/df92760bdce4
https://hg.mozilla.org/mozilla-central/rev/e153295a107e
Status: NEW → RESOLVED
Closed: 9 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla20
Whiteboard: [mno11]
Request to tef+ as this feature is required for v1.0.1
blocking-b2g: --- → tef?
blocking-b2g: tef? → shira?
Attachment #707544 - Flags: approval-mozilla-b2g18?
Comment on attachment 707544 [details] [diff] [review]
(b2g18) Part1: Support MORE_TIME in RIL, v4, r=allstars.chh

Request to approval-mozilla-b2g18+ as this feature is required for v1.0.1
Attachment #707544 - Flags: approval-mozilla-b2g18?
Comment on attachment 707545 [details] [diff] [review]
(b2g18) Part2: xpcshell tests for MORE_TIME, v3, r=allstars.chh

Request to approval-mozilla-b2g18+ as this feature is required for v1.0.1
Attachment #707545 - Flags: approval-mozilla-b2g18?
blocking-b2g: shira? → shira+
Comment on attachment 707544 [details] [diff] [review]
(b2g18) Part1: Support MORE_TIME in RIL, v4, r=allstars.chh

This is shira+, so it can land without approval (as long as it has r+)
Attachment #707544 - Flags: approval-mozilla-b2g18? → approval-mozilla-b2g18+
Attachment #707545 - Flags: approval-mozilla-b2g18? → approval-mozilla-b2g18+
You need to log in before you can comment on or make changes to this bug.