804680 - B2G STK: support MORE TIME

Status: RESOLVED FIXED

(Core :: DOM: Device Interfaces, defect)

Comment 1

[Edgar Chen [:edgar]]

MORE Time is sesssion 6.4.4 in TS 101.267 / TS 11.14

Comment 2

[Edgar Chen [:edgar]]

Attachment: Part1: IDL for MORE_TIME, v1

Comment 3

[Edgar Chen [:edgar]]

Attachment: Part2: Support MORE_TIME in RIL, v1

Comment 4

[Edgar Chen [:edgar]]

Attachment: Part3: xpcshell tests for MORE_TIME

Comment 5

[Edgar Chen [:edgar]]

Attachment: Part2: Support MORE_TIME in RIL, v2

1). correct typo "cndDetailed"
2). remove trailing space

Comment 6

[Edgar Chen [:edgar]]

Attachment: Part1: IDL for MORE_TIME, v2

1). rebase

Comment 7

[Edgar Chen [:edgar]]

Attachment: Part2: Support MORE_TIME in RIL, v3

1). rebase
2). mark as MORE_TIME supported.

Comment 8

[Edgar Chen [:edgar]]

Attachment: Part3: xpcshell tests for MORE_TIME, v2

1). rebase
2). use STK_CMD_MORE_TIME instead of 0x02

Comment 9

[Vicamo Yang [:vicamo][:vyang]]

Comment on attachment 683039 [details] [diff] [review]
Part1: IDL for MORE_TIME, v2

Review of attachment 683039 [details] [diff] [review]:
-----------------------------------------------------------------

"The ME shall take no extraordinary action when it receives this command, and all other operations shall be unaffected." Then why should we expose an event to content that nothing has to be done?

Comment 10

[Edgar Chen [:edgar]]

(In reply to Vicamo Yang [:vicamo][:vyang] from comment #9)
> Comment on attachment 683039 [details] [diff] [review]
> Part1: IDL for MORE_TIME, v2
> 
> Review of attachment 683039 [details] [diff] [review]:
> -----------------------------------------------------------------
> 
> "The ME shall take no extraordinary action when it receives this command,
> and all other operations shall be unaffected." Then why should we expose an
> event to content that nothing has to be done?

I think we may need to let application know currently SIM status is busy and need more time to process.

Comment 11

[Edgar Chen [:edgar]]

Hi, Michael

ETSI TS 102 223 V11.0.0, 
6.4.4  MORE TIME, 
"This procedure is provided to allow the CAT task in the UICC more time for processing, where the processing is so long that it is in danger of affecting normal operation, and clock stop prevents processing to take place in the background."

In Android STK document, this proactive command is marked as "Implement by Baseband".
http://www.kandroid.org/online-pdk/guide/stk.html

Dose it mean this command will be handled by modem?
Do you have any information about this? :)

Thanks

Comment 12

[Vicamo Yang [:vicamo][:vyang]]

(In reply to Edgar Chen [:edgar] from comment #11)
> Dose it mean this command will be handled by modem?
> Do you have any information about this? :)

Like what we have in PROFILE_DOWNLOAD, even modem firmware has already covered it and doesn't propagate that even up to Gecko, we'll still have to provide our own implementation.

Comment 13

[Edgar Chen [:edgar]]

Attachment: WIP, Part1: Support MORE_TIME in RIL, v4

1). remove IDL
2). send TERMINAL_RESPONSE (OK) in ril_worker

Comment 14

[Edgar Chen [:edgar]]

Attachment: WIP, Part2: xpcshell tests for MORE_TIME, v3

1). just rename title.

Comment 15

[Edgar Chen [:edgar]]

Attachment: Part1: Support MORE_TIME in RIL, v4

Comment 16

[Edgar Chen [:edgar]]

Attachment: Part2: xpcshell tests for MORE_TIME, v3

Comment 17

[Yoshi Cheng-Hao Huang [:allstars.chh][:allstarschh][:yoshi]]

Comment on attachment 685955 [details] [diff] [review]
Part1: Support MORE_TIME in RIL, v4

Review of attachment 685955 [details] [diff] [review]:
-----------------------------------------------------------------

Great,
remember to add r=me in your patch.

Comment 18

[Edgar Chen [:edgar]]

Attachment: Part1: Support MORE_TIME in RIL, v4, r=allstars.chh

1). rebase
2). add reviewer's name in patch after review+

Comment 19

[Edgar Chen [:edgar]]

Attachment: Part2: xpcshell tests for MORE_TIME, v3, r=allstars.chh

1). rebase
2). add reviewer's name in patch after review+

Comment 20

[Yoshi Cheng-Hao Huang [:allstars.chh][:allstarschh][:yoshi]]

https://hg.mozilla.org/integration/mozilla-inbound/rev/df92760bdce4
https://hg.mozilla.org/integration/mozilla-inbound/rev/e153295a107e

Comment 21

[Ed Morley [:emorley]]

https://hg.mozilla.org/mozilla-central/rev/df92760bdce4
https://hg.mozilla.org/mozilla-central/rev/e153295a107e

Comment 22

[Yoshi Cheng-Hao Huang [:allstars.chh][:allstarschh][:yoshi]]

Request to tef+ as this feature is required for v1.0.1

Comment 23

[Edgar Chen [:edgar]]

Attachment: (b2g18) Part1: Support MORE_TIME in RIL, v4, r=allstars.chh

Comment 24

[Edgar Chen [:edgar]]

Attachment: (b2g18) Part2: xpcshell tests for MORE_TIME, v3, r=allstars.chh

Patch for mozilla-b2g18

Comment 25

[Edgar Chen [:edgar]]

Comment on attachment 707544 [details] [diff] [review]
(b2g18) Part1: Support MORE_TIME in RIL, v4, r=allstars.chh

Request to approval-mozilla-b2g18+ as this feature is required for v1.0.1

Comment 26

[Edgar Chen [:edgar]]

Comment on attachment 707545 [details] [diff] [review]
(b2g18) Part2: xpcshell tests for MORE_TIME, v3, r=allstars.chh

Request to approval-mozilla-b2g18+ as this feature is required for v1.0.1

Comment 27

[Alex Keybl [:akeybl]]

Comment on attachment 707544 [details] [diff] [review]
(b2g18) Part1: Support MORE_TIME in RIL, v4, r=allstars.chh

This is shira+, so it can land without approval (as long as it has r+)

Comment 28

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/releases/mozilla-b2g18/rev/0137b96feea6
https://hg.mozilla.org/releases/mozilla-b2g18/rev/78b8cd9d057a