804687 - [b2g-bluetooth] Remove HfpCommandThread from BluetoothHfpManager

Status: RESOLVED FIXED

(Core :: DOM: Device Interfaces, defect)

Description

[Kyle Machulis [:qdot] [:kmachulis] (INACTIVE)]

BluetoothHfpManager maintains its own thread to make what used to be a blocking call that's now non-blocking. We should be able to just schedule future events for this.

Filing blocking? because this involves removal of an extra thread, and a static nsCOMPtr that shouldn't be there.

Comment 1

[Andrew Overholt [:overholt]]

Simple fix and blocking+ to avoid having to get aurora approval.

Comment 2

[Kyle Machulis [:qdot] [:kmachulis] (INACTIVE)]

Attachment: Patch 1 (v1) - Remove HfpCommandThread from HfpManager

Testing this myself, but if someone else could test this patch too, that'd be great.

Comment 3

[Kyle Machulis [:qdot] [:kmachulis] (INACTIVE)]

Seems to work fine on my phone.

Comment 4

[Eric Chou [:ericchou] [:echou]]

Comment on attachment 674909 [details] [diff] [review]
Patch 1 (v1) - Remove HfpCommandThread from HfpManager

Review of attachment 674909 [details] [diff] [review]:
-----------------------------------------------------------------

Looks great! Thanks for revising this part of code. Gina has tried this patch and everything looked good. :)

::: dom/bluetooth/BluetoothHfpManager.cpp
@@ +180,2 @@
>  
> +    if(sStopSendingRingFlag) {

Nit: needs an additional space after 'if'

@@ +183,3 @@
>      }
>  
> +    if(!gBluetoothHfpManager) {

Nit: needs an additional space after 'if'

@@ +184,5 @@
>  
> +    if(!gBluetoothHfpManager) {
> +      NS_WARNING("BluetoothHfpManager no longer exists, cannot send ring!");
> +      return;
> +    } 

Nit: trailing space

@@ +185,5 @@
> +    if(!gBluetoothHfpManager) {
> +      NS_WARNING("BluetoothHfpManager no longer exists, cannot send ring!");
> +      return;
> +    } 
> +    gBluetoothHfpManager->SendLine("RING");    

Nit: trailing space

Comment 5

[Kyle Machulis [:qdot] [:kmachulis] (INACTIVE)]

http://hg.mozilla.org/integration/mozilla-inbound/rev/e58288ffbfa0

Comment 6

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/mozilla-central/rev/e58288ffbfa0

Comment 7

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/releases/mozilla-aurora/rev/b73c1929073f