security/manager/ssl/tests/unit/test_bug627234.js is perma-orange on Thunderbird's comm-*

RESOLVED FIXED in mozilla19

Status

()

Core
Security
--
major
RESOLVED FIXED
6 years ago
6 years ago

People

(Reporter: mconley, Assigned: mconley)

Tracking

unspecified
mozilla19
x86
All
Points:
---
Bug Flags:
in-testsuite +

Firefox Tracking Flags

(Not tracked)

Details

Attachments

(1 attachment)

Not sure if this is the right component for this one, but Thunderbird has been perma-oranged by a test in security/manager/ssl/tests/ that assumes that private browsing is a registered component.
Created attachment 674305 [details] [diff] [review]
Patch v1

This patch checks for the private browsing service, and if it isn't registered, skips the test.
Assignee: nobody → mconley
Attachment #674305 - Flags: review?(bsmith)
This was caused by bug 627234 and is now on aurora and beta as well as the test has also landed on those branches.
Blocks: 627234
Severity: normal → major
Summary: security/manager/ssl/tests/unit/test_bug627234.js is perma-orange on comm-central → security/manager/ssl/tests/unit/test_bug627234.js is perma-orange on Thunderbird's comm-*
Comment on attachment 674305 [details] [diff] [review]
Patch v1

Maybe David Keeler has some cycles?
Attachment #674305 - Flags: review?(bsmith) → review?(dkeeler)
Comment on attachment 674305 [details] [diff] [review]
Patch v1

Review of attachment 674305 [details] [diff] [review]:
-----------------------------------------------------------------

Looks good. Sorry this happened again. Hopefully I'll remember next time.
Attachment #674305 - Flags: review?(dkeeler) → review+
Comment on attachment 674305 [details] [diff] [review]
Patch v1

Review of attachment 674305 [details] [diff] [review]:
-----------------------------------------------------------------

I get nervous about these "if we can't get the private browsing service then succeed without running the test" tests. It seems like there should be some test component with a function that returns true if private browsing is supposed to work, and false if private browsing isn't supposed to work--perhaps a "disable private browsing" pref that Thunderbird can set and Firefox can leave unset. Something for the future, I guess.
Attachment #674305 - Flags: superreview+
https://hg.mozilla.org/mozilla-central/rev/6ddc79908e64
Status: NEW → RESOLVED
Last Resolved: 6 years ago
Flags: in-testsuite+
Resolution: --- → FIXED
Target Milestone: --- → mozilla19
Comment on attachment 674305 [details] [diff] [review]
Patch v1

Bug 627234 landed on Aurora and Beta as well, and has busted Thunderbird's tests there too.

[Approval Request Comment]
Bug caused by (feature/regressing bug #): 627234
User impact if declined: None.
Testing completed (on m-c, etc.): mozilla-central
Risk to taking this patch (and alternatives if risky): Very little, since it's only test related.
String or UUID changes made by this patch: None.
Attachment #674305 - Flags: approval-mozilla-beta?
Attachment #674305 - Flags: approval-mozilla-aurora?
Comment on attachment 674305 [details] [diff] [review]
Patch v1

I've been told tha test only fixes can land with a=testonly (which is how the original test landed), so we don't need explicit approval here.
Attachment #674305 - Flags: approval-mozilla-beta?
Attachment #674305 - Flags: approval-mozilla-aurora?
You need to log in before you can comment on or make changes to this bug.