804738 - Codegen for named getters/setters hardcodes 'name' for the first argument

Status: RESOLVED FIXED

(Core :: DOM: Core & HTML, defect)

Description

[:Ms2ger (he/him; ⌚ UTC+1/+2)]

OTOH, the call into native code uses the name from the IDL file, which gives something like

    FakeDependentString name;
    ...
    self->NamedSetter(key, value, rv);

Comment 1

[Boris Zbarsky [:bzbarsky]]

Attachment: part 1. Fix codegen for named operations to be consistent about the naming of the string argument.

Comment 2

[Boris Zbarsky [:bzbarsky]]

Attachment: part 2. Fix codegen for indexed operations to be consistent about the naming of the index argument.

Comment 3

[Boris Zbarsky [:bzbarsky]]

   https://hg.mozilla.org/integration/mozilla-inbound/rev/02cff46d3ebd
   https://hg.mozilla.org/integration/mozilla-inbound/rev/3d13288fd977

Thanks for the reviews!

Comment 4

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/mozilla-central/rev/02cff46d3ebd
https://hg.mozilla.org/mozilla-central/rev/3d13288fd977