804828 - Talagent trips ValidWriteAssert (when Firefox tries to restart in safe mode due to previous crashes)

Status: RESOLVED FIXED

(Core :: XPCOM, defect)

Description

[Jesse Ruderman]

Attachment: log with stack

Assertion failure: ok, at /Users/jruderman/trees/mozilla-central/xpcom/build/mozPoisonWriteMac.cpp:54

Comment 1

[Rafael Ávila de Espíndola (:espindola) (not reading bugmail)]

Can you put a breakpoint in mozilla::PoisonWrite? Writes should only be poisoned during shutdown, but looks like they are being poisoned during startup in your case!

Comment 2

[Jesse Ruderman]

Attachment: stack to mozilla::PoisonWrite

I think it's shutting down early in order to restart itself in safe mode.

Comment 3

[Rafael Ávila de Espíndola (:espindola) (not reading bugmail)]

Attachment: Only poison writes during a regular shutdown

For the exit(0) work we only need to check the writes in a regular shutdown. Avoid poisoning during other paths.

In the future the point where we poison will hopefully be before ShutdownXPCOM, but for now we need a way to tell  mozilla::PoisonWrite to avoid patching the writes.

Comment 4

[Rafael Ávila de Espíndola (:espindola) (not reading bugmail)]

https://hg.mozilla.org/integration/mozilla-inbound/rev/d4fe281305ce

Comment 5

[Ed Morley [:emorley]]

https://hg.mozilla.org/mozilla-central/rev/d4fe281305ce