804833 - Allow PR_FormatTime and PR_FormatTimeUSEnglish with NO_NSPR_10_SUPPORT

Status: RESOLVED FIXED

(NSPR :: NSPR, defect, P1)

Description

[Wan-Teh Chang]

Attachment: Allow PR_FormatTime and PR_FormatTimeUSEnglish, by Isaac Aggrey

Right now PR_FormatTime and PR_FormatTimeUSEnglish are disallowed
if NO_NSPR_10_SUPPORT is defined. This is problematic when people
try to compile their code with -DNO_NSPR_10_SUPPORT.

I think it is fine to officially recognize these two functions as
supported. We should document clearly that PR_FormatTime is based
on strftime(). We probably should also change its 'buflen' parameter
to PRUint32.

The first patch is from Isaac Aggrey in bug 802430 (attachment 674333 [details] [diff] [review]).

Comment 1

[Wan-Teh Chang]

Comment on attachment 674442 [details] [diff] [review]
Allow PR_FormatTime and PR_FormatTimeUSEnglish, by Isaac Aggrey

Patch checked in on the NSPR trunk (NSPR 4.9.4).

Checking in prtime.h;
/cvsroot/mozilla/nsprpub/pr/include/prtime.h,v  <--  prtime.h
new revision: 3.15; previous revision: 3.14
done

Comment 2

[Wan-Teh Chang]

Pushed to mozilla-inbound as part of NSPR_4_9_4_BETA1:
https://hg.mozilla.org/integration/mozilla-inbound/rev/0d124d4f28b0

Comment 3

[Wan-Teh Chang]

https://hg.mozilla.org/mozilla-central/rev/0d124d4f28b0

Issac, if there is nothing else that needs to be done, please
mark the bug FIXED. Thanks.

Comment 4

[(no longer active)]

Thanks, Wan-Teh!

Comment 5

[Isaac Aggrey [:isaac]]

(In reply to Wan-Teh Chang from comment #3)
> https://hg.mozilla.org/mozilla-central/rev/0d124d4f28b0
> 
> Issac, if there is nothing else that needs to be done, please
> mark the bug FIXED. Thanks.

Ehsan beat me to the punch; I wasn't sure if I needed to wait until it hit mozilla-central. Thanks Wan-Teh!