Right now PR_FormatTime and PR_FormatTimeUSEnglish are disallowed if NO_NSPR_10_SUPPORT is defined. This is problematic when people try to compile their code with -DNO_NSPR_10_SUPPORT. I think it is fine to officially recognize these two functions as supported. We should document clearly that PR_FormatTime is based on strftime(). We probably should also change its 'buflen' parameter to PRUint32. The first patch is from Isaac Aggrey in bug 802430 (attachment 674333 [details] [diff] [review]).
Attachment #674442 - Flags: review+
Comment on attachment 674442 [details] [diff] [review] Allow PR_FormatTime and PR_FormatTimeUSEnglish, by Isaac Aggrey Patch checked in on the NSPR trunk (NSPR 4.9.4). Checking in prtime.h; /cvsroot/mozilla/nsprpub/pr/include/prtime.h,v <-- prtime.h new revision: 3.15; previous revision: 3.14 done
Pushed to mozilla-inbound as part of NSPR_4_9_4_BETA1: https://hg.mozilla.org/integration/mozilla-inbound/rev/0d124d4f28b0
https://hg.mozilla.org/mozilla-central/rev/0d124d4f28b0 Issac, if there is nothing else that needs to be done, please mark the bug FIXED. Thanks.
Status: ASSIGNED → RESOLVED
Closed: 7 years ago
Resolution: --- → FIXED
(In reply to Wan-Teh Chang from comment #3) > https://hg.mozilla.org/mozilla-central/rev/0d124d4f28b0 > > Issac, if there is nothing else that needs to be done, please > mark the bug FIXED. Thanks. Ehsan beat me to the punch; I wasn't sure if I needed to wait until it hit mozilla-central. Thanks Wan-Teh!
You need to log in before you can comment on or make changes to this bug.